Re: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"
Reviewed-by: Jaben Carsey
Thanks
-Jaben
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, August 13, 2019 8:37 PM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: RE: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove
> the variable "Index"
>
> Reviewed-by: Zhichao Gao
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: Zhang, Shenglei
> > Sent: Wednesday, August 14, 2019 11:07 AM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben ; Ni, Ray ;
> > Gao, Zhichao
> > Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove
> the
> > variable "Index"
> >
> > In IortParser.c ,the variable Index is set but not used in function
> > DumpIortNodeNamedComponent. This will cause build failure when
> building
> > ShellPkg with GCC.
> >
> > Cc: Jaben Carsey
> > Cc: Ray Ni
> > Cc: Zhichao Gao
> > Signed-off-by: Shenglei Zhang
> > ---
> > .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> > index 8912d415a755..f1cdb9ac01d8 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> > +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars
> > +++ er.c
> > @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent (
> >)
> > {
> >UINT32 Offset;
> > - UINT32 Index;
> >
> >Offset = ParseAcpi (
> > TRUE,
> > @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent (
> >
> >// Estimate the Device Name length
> >PrintFieldName (2, L"Device Object Name");
> > - Index = 0;
> >
> >while ((*(Ptr + Offset) != 0) &&
> > (Offset < Length)) {
> > --
> > 2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#45612): https://edk2.groups.io/g/devel/message/45612
Mute This Topic: https://groups.io/mt/32860379/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, August 14, 2019 11:07 AM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the
> variable "Index"
>
> In IortParser.c ,the variable Index is set but not used in function
> DumpIortNodeNamedComponent. This will cause build failure when building
> ShellPkg with GCC.
>
> Cc: Jaben Carsey
> Cc: Ray Ni
> Cc: Zhichao Gao
> Signed-off-by: Shenglei Zhang
> ---
> .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> index 8912d415a755..f1cdb9ac01d8 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars
> +++ er.c
> @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent (
>)
> {
>UINT32 Offset;
> - UINT32 Index;
>
>Offset = ParseAcpi (
> TRUE,
> @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent (
>
>// Estimate the Device Name length
>PrintFieldName (2, L"Device Object Name");
> - Index = 0;
>
>while ((*(Ptr + Offset) != 0) &&
> (Offset < Length)) {
> --
> 2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#45582): https://edk2.groups.io/g/devel/message/45582
Mute This Topic: https://groups.io/mt/32860379/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"
In IortParser.c ,the variable Index is set but not used in
function DumpIortNodeNamedComponent. This will cause build failure
when building ShellPkg with GCC.
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
.../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 2 --
1 file changed, 2 deletions(-)
diff --git
a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
index 8912d415a755..f1cdb9ac01d8 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
@@ -472,7 +472,6 @@ DumpIortNodeNamedComponent (
)
{
UINT32 Offset;
- UINT32 Index;
Offset = ParseAcpi (
TRUE,
@@ -485,7 +484,6 @@ DumpIortNodeNamedComponent (
// Estimate the Device Name length
PrintFieldName (2, L"Device Object Name");
- Index = 0;
while ((*(Ptr + Offset) != 0) &&
(Offset < Length)) {
--
2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#45579): https://edk2.groups.io/g/devel/message/45579
Mute This Topic: https://groups.io/mt/32860379/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
