On 07/16/19 16:59, Philippe Mathieu-Daudé wrote:
> On 7/16/19 4:14 PM, Laszlo Ersek wrote:
>> On 07/16/19 11:41, Philippe Mathieu-Daudé wrote:
>>> Hi Laszlo,
>>>
>>> On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote:
On 7/2/19 12:28 PM, Laszlo Ersek wrote:
> Rewrite Base64Decode() from
On 07/16/19 16:56, Gao, Liming wrote:
> Laszlo:
> Yes. Patch 1 & Patch 2 in MdePkg are both good to me. I have no other
> comments. Reviewed-by: Liming Gao
Many thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43809):
On 7/16/19 4:14 PM, Laszlo Ersek wrote:
> On 07/16/19 11:41, Philippe Mathieu-Daudé wrote:
>> Hi Laszlo,
>>
>> On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote:
>>> On 7/2/19 12:28 PM, Laszlo Ersek wrote:
Rewrite Base64Decode() from scratch, due to reasons listed in the second
reference
:49 PM
> To: Gao, Liming ; Kinney, Michael D
>
> Cc: edk2-devel-groups-io ; Marvin Häuser
> ; Philippe Mathieu-Daudé
> ; Gao, Zhichao
> Subject: Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify
> Base64Decode(), and add temporary stub impl
>
> sending a separa
On 07/16/19 11:41, Philippe Mathieu-Daudé wrote:
> Hi Laszlo,
>
> On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote:
>> On 7/2/19 12:28 PM, Laszlo Ersek wrote:
>>> Rewrite Base64Decode() from scratch, due to reasons listed in the second
>>> reference below.
>>>
>>> As first step, redo the
sending a separate ping here as well, for clarity -- Liming, Mike, can
one of you please R-b or A-b this specific patch too?
Thanks!
Laszlo
On 07/02/19 12:28, Laszlo Ersek wrote:
> Rewrite Base64Decode() from scratch, due to reasons listed in the second
> reference below.
>
> As first step,
Hi Laszlo,
On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote:
> On 7/2/19 12:28 PM, Laszlo Ersek wrote:
>> Rewrite Base64Decode() from scratch, due to reasons listed in the second
>> reference below.
>>
>> As first step, redo the interface contract, and replace the current
>> implementation with
On 7/2/19 12:28 PM, Laszlo Ersek wrote:
> Rewrite Base64Decode() from scratch, due to reasons listed in the second
> reference below.
>
> As first step, redo the interface contract, and replace the current
> implementation with a stub that asserts FALSE, then fails.
>
> Cc: Liming Gao
> Cc: