On 06/28/19 05:57, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1891 > > DestinationSize is decripted as 'Set to bytes stored on return'. > Before return the status, set its converted bytes to be complied > to the decriptions. > DestinationIndex may be overflow if the *DestinationSize is bigger > than (MAX_ADDRESS - 1). Move its incrementation under condition > 'DestinationIndex < *DestinationSize' to make sure it wouldn't be > overflow. > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Marvin Hauser <mhaeu...@outlook.de> > Cc: Laszlo Ersek <ler...@redhat.com> > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > --- > MdePkg/Library/BaseLib/String.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-)
I'm going to skip this patch because, as I stated under the blurb, I believe that the basic approach of the function implementation is wrong. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43117): https://edk2.groups.io/g/devel/message/43117 Mute This Topic: https://groups.io/mt/32238989/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
