Re: [edk2-devel] [PATCH 7/8] AlderlakeSiliconPkg/SystemAgent: Add include headers
Reviewed-by: Sai Chaganty
-Original Message-
From: Kasbekar, Saloni
Sent: Thursday, June 15, 2023 10:53 AM
To: devel@edk2.groups.io
Cc: Kasbekar, Saloni ; Chaganty, Rangasai V
; Desimone, Nathaniel L
; Oram, Isaac W ;
Chuang, Rosen
Subject: [PATCH 7/8] AlderlakeSiliconPkg/SystemAgent: Add include headers
Adds the following header files:
* SystemAgent/Include
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
.../Include/ConfigBlock/MemoryDxeConfig.h | 126 ++
.../ConfigBlock/SaMiscPeiPreMemConfig.h | 112 +
.../Include/Library/DxeSaPolicyLib.h | 58 +
.../Include/Library/PeiSaPolicyLib.h | 13 ++
.../SystemAgent/Include/MemInfoHob.h | 220 ++
.../SystemAgent/Include/Protocol/SaPolicy.h | 54 +
.../SystemAgent/Include/SaDataHob.h | 28 +++
7 files changed, 611 insertions(+)
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/SaMiscPeiPreMemConfig.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/Library/DxeSaPolicyLib.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/Library/PeiSaPolicyLib.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/MemInfoHob.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/Protocol/SaPolicy.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/SaDataHob.h
diff --git
a/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h
b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h
new file mode 100644
index 00..eca0c2f1ba
--- /dev/null
+++ b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/
+++ MemoryDxeConfig.h
@@ -0,0 +1,126 @@
+/** @file
+ Memory DXE Policy definitions
+
+ Copyright (c) 2022, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent **/ #ifndef
+_MEMORY_DXE_CONFIG_H_ #define _MEMORY_DXE_CONFIG_H_
+
+#pragma pack(push, 1)
+
+/**
+ Making any setup structure change after code frozen will need to
+maintain backward compatibility, bump up structure revision and update
+below history table\n
+ Revision 1: - Initial version.
+**/
+#define MEMORY_DXE_CONFIG_REVISION 2
+
+typedef struct _MEMORY_DXE_CONFIG MEMORY_DXE_CONFIG;
+
+/**
+ Retrieves the OEM custom string for the SMBIOS Type 17 Table DeviceLocator
field.
+ Implementation of this function is optional, if this function pointer
+is NULL then
+ the reference implementation of DeviceLocator will be used.
+
+ @param[in] This A pointer to this instance of
MEMORY_DXE_CONFIG.
+ @param[in] ControllerDesired Controller to get a
DeviceLocator string for.
+ @param[in] Dimm Desired DIMM to get a
DeviceLocator string for.
+ @param[in] MdSocket 0 = Memory Down, 1 = Socketed.
+
+ @retval The DeviceLocator string
+ @retval NULL If the return value is NULL, the
default value will be used.
+**/
+typedef
+CHAR8*
+(EFIAPI *MEMORY_DXE_CONFIG_GET_DEVICE_LOCATOR_STRING)(
+ IN CONSTMEMORY_DXE_CONFIG *This,
+ IN UINT8 Controller,
+ IN UINT8 Dimm,
+ IN UINT8 MdSocket
+ );
+
+/**
+ Retrieves the OEM custom string for the SMBIOS Type 17 Table BankLocator
field.
+ Implementation of this function is optional, if this function pointer
+is NULL then
+ the reference implementation of DeviceLocator will be used.
+
+ @param[in] This A pointer to this instance of
MEMORY_DXE_CONFIG.
+ @param[in] ControllerDesired Controller to get a
BankLocator string for.
+ @param[in] Dimm Desired DIMM to get a BankLocator
string for.
+ @param[in] MdSocket 0 = Memory Down, 1 = Socketed.
+
+ @retval The BankLocator string
+ @retval NULL If the return value is NULL, the
default value will be used.
+**/
+typedef
+CHAR8*
+(EFIAPI *MEMORY_DXE_CONFIG_GET_BANK_LOCATOR_STRING)(
+ IN CONSTMEMORY_DXE_CONFIG *This,
+ IN UINT8 Controller,
+ IN UINT8 Dimm,
+ IN UINT8 MdSocket
+ );
+
+/**
+ The Memory Configuration includes DIMM SPD address Map and DIMM Slot
Mechanical present bit map.
+ The data elements should be initialized by a Platform Module.\n
+ Revision 1:
+ - Initial version.
+**/
+struct _MEMORY_DXE_CONFIG {
+ CONFIG_BLOCK_HEADER Header; ///< Offset 0-27: Config
Block Header
+/**
+ Offset
[edk2-devel] [PATCH 7/8] AlderlakeSiliconPkg/SystemAgent: Add include headers
Adds the following header files:
* SystemAgent/Include
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Rosen Chuang
Signed-off-by: Saloni Kasbekar
---
.../Include/ConfigBlock/MemoryDxeConfig.h | 126 ++
.../ConfigBlock/SaMiscPeiPreMemConfig.h | 112 +
.../Include/Library/DxeSaPolicyLib.h | 58 +
.../Include/Library/PeiSaPolicyLib.h | 13 ++
.../SystemAgent/Include/MemInfoHob.h | 220 ++
.../SystemAgent/Include/Protocol/SaPolicy.h | 54 +
.../SystemAgent/Include/SaDataHob.h | 28 +++
7 files changed, 611 insertions(+)
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/SaMiscPeiPreMemConfig.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/Library/DxeSaPolicyLib.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/Library/PeiSaPolicyLib.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/MemInfoHob.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/Protocol/SaPolicy.h
create mode 100644
Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/SaDataHob.h
diff --git
a/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h
b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h
new file mode 100644
index 00..eca0c2f1ba
--- /dev/null
+++
b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h
@@ -0,0 +1,126 @@
+/** @file
+ Memory DXE Policy definitions
+
+ Copyright (c) 2022, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+**/
+#ifndef _MEMORY_DXE_CONFIG_H_
+#define _MEMORY_DXE_CONFIG_H_
+
+#pragma pack(push, 1)
+
+/**
+ Making any setup structure change after code frozen
+ will need to maintain backward compatibility, bump up
+ structure revision and update below history table\n
+ Revision 1: - Initial version.
+**/
+#define MEMORY_DXE_CONFIG_REVISION 2
+
+typedef struct _MEMORY_DXE_CONFIG MEMORY_DXE_CONFIG;
+
+/**
+ Retrieves the OEM custom string for the SMBIOS Type 17 Table DeviceLocator
field.
+ Implementation of this function is optional, if this function pointer is
NULL then
+ the reference implementation of DeviceLocator will be used.
+
+ @param[in] This A pointer to this instance of
MEMORY_DXE_CONFIG.
+ @param[in] ControllerDesired Controller to get a
DeviceLocator string for.
+ @param[in] Dimm Desired DIMM to get a
DeviceLocator string for.
+ @param[in] MdSocket 0 = Memory Down, 1 = Socketed.
+
+ @retval The DeviceLocator string
+ @retval NULL If the return value is NULL, the
default value will be used.
+**/
+typedef
+CHAR8*
+(EFIAPI *MEMORY_DXE_CONFIG_GET_DEVICE_LOCATOR_STRING)(
+ IN CONSTMEMORY_DXE_CONFIG *This,
+ IN UINT8 Controller,
+ IN UINT8 Dimm,
+ IN UINT8 MdSocket
+ );
+
+/**
+ Retrieves the OEM custom string for the SMBIOS Type 17 Table BankLocator
field.
+ Implementation of this function is optional, if this function pointer is
NULL then
+ the reference implementation of DeviceLocator will be used.
+
+ @param[in] This A pointer to this instance of
MEMORY_DXE_CONFIG.
+ @param[in] ControllerDesired Controller to get a
BankLocator string for.
+ @param[in] Dimm Desired DIMM to get a BankLocator
string for.
+ @param[in] MdSocket 0 = Memory Down, 1 = Socketed.
+
+ @retval The BankLocator string
+ @retval NULL If the return value is NULL, the
default value will be used.
+**/
+typedef
+CHAR8*
+(EFIAPI *MEMORY_DXE_CONFIG_GET_BANK_LOCATOR_STRING)(
+ IN CONSTMEMORY_DXE_CONFIG *This,
+ IN UINT8 Controller,
+ IN UINT8 Dimm,
+ IN UINT8 MdSocket
+ );
+
+/**
+ The Memory Configuration includes DIMM SPD address Map and DIMM Slot
Mechanical present bit map.
+ The data elements should be initialized by a Platform Module.\n
+ Revision 1:
+ - Initial version.
+**/
+struct _MEMORY_DXE_CONFIG {
+ CONFIG_BLOCK_HEADER Header; ///< Offset 0-27: Config
Block Header
+/**
+ Offset 28:
+ Dimm SPD address
+ Only Server support 2 channels * 3 slots per channel = 6 sockets totally
+ The Desktop and mobile only support 2 channels * 2 slots per channel = 4
sockets totally
+ So there is mapping rule here for Desktop and mobile that there are no more
4 DIMMS totally in a system:
+Channel A/ Slot 0 -->
