Re: Microsoft imports - was Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-08-07 Thread Liming Gao
Michael D ; >Gao, Liming >Subject: Microsoft imports - was Re: [edk2-devel] [PATCH V2] BaseTools:Add >extra debugging message > >So, I'm not going to give any of the reviewers a hard time about this >- the patch *looks* right and we've all occasionally given R-b on >things we haven't

Re: Microsoft imports - was Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-08-02 Thread rebecca
On 2019-08-02 03:55, Leif Lindholm wrote: > One change I would like to see enacted *immediately* is that *any* > imports from other open source projects state the repository and the > commit hash that it originated from. In the commit message - and where > BZs are referenced in the message, also

Re: Microsoft imports - was Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-08-02 Thread Philippe Mathieu-Daudé
gt;> >>> -Original Message- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Fan, >>> ZhijuX >>> Sent: Thursday, July 25, 2019 11:02 AM >>> To: devel@edk2.groups.io >>> Cc: Max Knutsen ; Feng, Bob C >&g

Microsoft imports - was Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-08-02 Thread Leif Lindholm
, August 1, 2019 8:20 PM > > To: devel@edk2.groups.io; Fan, ZhijuX > > Cc: Max Knutsen ; Gao, Liming > > Subject: RE: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message > > > > Hi Zhiju, > > > > There is a typo in this patch. See it inline. > >

Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-08-01 Thread Liming Gao
July 25, 2019 11:02 AM > To: devel@edk2.groups.io > Cc: Max Knutsen ; Feng, Bob C ; > Gao, Liming ; Fan, ZhijuX > > Subject: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message > > From: Max Knutsen > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2014 &

Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-07-26 Thread Liming Gao
>-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Philippe Mathieu-Daudé >Sent: Thursday, July 25, 2019 7:04 PM >To: devel@edk2.groups.io; Fan, ZhijuX >Cc: Max Knutsen ; Feng, Bob C >; Gao, Liming >Subject: Re

Re: [edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-07-25 Thread Philippe Mathieu-Daudé
Nit in subject, "BaseTools:Add extra debugging message" On 7/25/19 5:02 AM, Fan, ZhijuX wrote: > From: Max Knutsen > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2014 > > Add extra debugging to improve error identification. > Error while processing file if the file is read incorrectly >

[edk2-devel] [PATCH V2] BaseTools:Add extra debugging message

2019-07-24 Thread Fan, ZhijuX
From: Max Knutsen BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2014 Add extra debugging to improve error identification. Error while processing file if the file is read incorrectly This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan ---