Reply inline.
> -Original Message-
> From: Wang, Jian J
> Sent: Monday, October 7, 2019 11:08 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney, Michael
> D ; Ni, Ray ; Wu, Hao A
> ; Yao, Jiewen
The rationale for moving the generic parsing functions out would be better to
capture in the
commit message. That will be added to V3.
Thanks,
Michael
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, October 7, 2019 7:12 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc:
Michael,
One comment below.
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, September 28, 2019 9:47 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney, Michael D
> ; Ni, Ray ; Wang, Jian J
> ; Wu, Hao
> -Original Message-
> From: Kubacki, Michael A
> Sent: Friday, October 04, 2019 1:36 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Yao, Jiewen
> Subject: RE: [PATCH V2 1/9]
The main reason is cohesiveness in the VariableParsing.c file. These are
functions that
are commonly needed for general variable data structure parsing operations.
Most of
them just read a member or two in a VARIABLE_STORE_HEADER or VARIABLE_HEADER
data structure, perform a simple calculation
A couple of inline comments below:
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, September 28, 2019 9:47 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao,
This change moves the following functions into a dedicated file
so they may be used in other variable files as needed. Furthermore,
it reduces the overall size of the common Variable.c file.
* DataSizeOfVariable ()
* FindVariableEx ()
* GetEndPointer ()
* GetNextVariablePtr ()
*
