nney, Michael D ; Gao, Liming
> ; Vitaly Cheptsov
> Subject: RE: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate
> the lib instances
>
> Ray,
>
> Your suggestion is good for open source, but unfriendly to the close source
> platforms which consume this lib.
more code duplication
> IMO.
>
> Thanks,
> Ray
>
> > -Original Message-
> > From: Gao, Zhichao
> > Sent: Friday, December 20, 2019 2:41 PM
> > To: Ni, Ray ; devel@edk2.groups.io
> > Cc: Kinney, Michael D ; Gao, Liming
> > ; Vitaly Cheptsov
>
age-
> From: Gao, Zhichao
> Sent: Friday, December 20, 2019 2:41 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Vitaly Cheptsov
> Subject: RE: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib:
> Separate the lib instances
>
> For ope
> To: Gao, Zhichao ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Vitaly Cheptsov
> Subject: RE: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate
> the lib instances
>
> Removing code duplication is great.
>
> But your patch introduces
DevicePathLib path.
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: Ni, Ray
> > Sent: Friday, December 20, 2019 1:50 PM
> > To: devel@edk2.groups.io; Gao, Zhichao
> > Cc: Kinney, Michael D ; Gao, Liming
> > ; Vitaly Cheptsov
> > Subj
9 1:50 PM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Kinney, Michael D ; Gao, Liming
> ; Vitaly Cheptsov
> Subject: RE: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate
> the lib instances
>
> Zhichao,
> \MdePkg\Library\UefiDevicePathLibDevicePathProtocol\
December 18, 2019 10:11 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Vitaly Cheptsov
> Subject: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate
> the lib instances
>
> REF: https://bugzilla.t
On Behalf Of Vitaly Cheptsov
via Groups.Io
Sent: Wednesday, December 18, 2019 4:27 PM
To: Gao, Zhichao ; devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
Subject: Re: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate
the lib instances
This makes very good sense to me, thank
This makes very good sense to me, thank you for taking your time to fix it.
I am slightly unsure whether if checks with subsequent assertions are really
needed in mandatory version, as asserting in the constructor will trigger
missing protocol very early anyway, but I do not think it is
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298
The UefiDevicePathLibOptionalDevicePathProtocolConstructor's implementation
isn't match with its instance name.
Remove the ASSERT and depex of the gEfiDevicePathUtilitiesProtocolGuid
because of "Optional".
Add a mandatory instance to force
10 matches
Mail list logo
