Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-29 Thread Bob Feng
OK. For this patch, Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, May 29, 2019 4:25 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Gao, Liming Subject: RE: [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE The Dict parameter

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-29 Thread Fan, ZhijuX
The Dict parameter is not used in this function, I will enter an BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1858 to clean up the unused parameters Any question, please let me know. Thanks. Best Regards Fan Zhiju > -Original Message- > From: Feng, Bob C > Sent: Wednesday,

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-29 Thread Bob Feng
Hi Zhiju, For the changes, -def __InfParse__(self, Dict = {}): +def __InfParse__(self, Dict = None, IsGenFfs=False): and -def GetFileList(FfsInf, FileType, FileExtension, Dict = {}, IsMakefile=False): +def GetFileList(FfsInf, FileType, FileExtension, Dict = None,

Re: [edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-29 Thread Liming Gao
Tested-by: Liming Gao >-Original Message- >From: Fan, ZhijuX >Sent: Wednesday, May 29, 2019 1:30 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [PATCH V5] BaseTools:Make BaseTools support new rules to >generate RAW FFS FILE >

[edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-28 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1765 If RAW FFS File Rule has no section for its data.For RAW FFS File, directly call GenFfs tool to generate FFS file. Ffs Rule: [Rule.Common.USER_DEFINED.MicroCode] FILE RAW = $(NAMED_GUID) { $(INF_OUTPUT)/$(MODULE_NAME).bin }