, Christine
Subject: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make Ecc only check first
include guard
From: Pierre Gondois
The Ecc tool checks the format of the include guard. This check is currently
done on all the names following the '#ifndef' statement.
It should only be done on the first
Pierre:
I see. This change is good to me. Reviewed-by: Liming Gao
Thanks
Liming
发件人: PierreGondois
发送时间: 2021年3月11日 17:26
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make Ecc
only check first include guard
Hello Liming
Hello Liming,
Yes this check is only done for '.h' files. Cf the bit of code from the same
file:
if os.path.splitext(F)[1] in ('.h'):
self.NamingConventionCheckIfndefStatement(FileTable)
I think this is normal, the format of the initial 'ifndef' needs to be
formatted as 'Name_', but not
Is this checker for .h file only?
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表
> PierreGondois
> 发送时间: 2021年3月10日 0:17
> 收件人: devel@edk2.groups.io; bob.c.f...@intel.com;
> gaolim...@byosoft.com.cn; yuwei.c...@intel.com
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make
From: Pierre Gondois
The Ecc tool checks the format of the include guard. This check is
currently done on all the names following the '#ifndef' statement.
It should only be done on the first include guard.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3252
Signed-off-by: Pierre Gondois
