On 10/21/19 11:58, Vitaly Cheptsov via Groups.Io wrote:
> Jiewen,
>
> We are aware of all these nuances, and you are right that both of them
> (strlcpy/strcpy_s) have their downsides. Our opinion is that strlcpy
> is more practical, but that is a personal choice, and we do nor care
> much on what
al Message-
>> From: vit9696
>> Sent: Monday, October 21, 2019 4:30 PM
>> To: Yao, Jiewen
>> Cc: devel@edk2.groups.io; Gao, Liming ; Wang, Jian J
>> ; Kinney, Michael D ;
>> Laszlo Ersek ; marvin.haeu...@outlook.com
>> Subject: Re: [edk2-devel] [PATCH v
> To: Yao, Jiewen
> Cc: devel@edk2.groups.io; Gao, Liming ; Wang, Jian J
> ; Kinney, Michael D ;
> Laszlo Ersek ; marvin.haeu...@outlook.com
> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe
> string
> constraint assertions
>
> Jiewen,
&g
; Sent: Monday, October 21, 2019 3:28 PM
>> To: Yao, Jiewen ; Gao, Liming
>> Cc: devel@edk2.groups.io; Wang, Jian J ; Kinney,
>> Michael D
>> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe
>> string
>> constraint assertions
&
t; >
> > What is your thought?
> >
> > Thank you
> > Yao Jiewen
> >
> >> -Original Message-
> >> From: Gao, Liming
> >> Sent: Monday, October 21, 2019 11:17 AM
> >> To: devel@edk2.groups.io; vit9...@protonmail.co
...@protonmail.com
>> Cc: Yao, Jiewen ; Wang, Jian J ;
>> Gao, Liming ; Kinney, Michael D
>>
>> Subject: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe
>> string
>> constraint assertions
>>
>> Include more people.
>>
>> B
ael D
>
> Subject: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe
> string
> constraint assertions
>
> Include more people.
>
> Basically, to keep the compatible behavior, PcdAssertOnSafeStringConstraints
> default value should be TRUE.
> The
gt;Vitaly Cheptsov via Groups.Io
>Sent: Sunday, October 20, 2019 9:06 PM
>To: devel@edk2.groups.io
>Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe string
>constraint assertions
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
>
>Runtime data ch
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
Runtime data checks are not meant to cause debug assertions
unless explicitly needed by some debug code (thus the PCD)
as this breaks debug builds validating data with BaseLib.
Signed-off-by: Vitaly Cheptsov >
---
MdePkg/MdePkg.dec
