Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.
Hi all, With this patch checked in, you may meet build failure with MdeModulePkg. Because the components in oniguruma can’t be found. Please try command " git submodule update --init" to check out the source code before you build the package. Thanks, Shenglei > -Original Message- > From: Gao, Liming > Sent: Thursday, March 12, 2020 11:12 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make > oniguruma a submodule in edk2. > > Reviewed-by: Liming Gao > > -Original Message- > From: Zhang, Shenglei > Sent: 2020年3月9日 15:28 > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make > oniguruma a submodule in edk2. > > Use submodule way to access oniguruma. And upgrade oniguruma > version from v6.9.3 to v6.9.4_mark1. > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073 > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > > v2: Include wrapper files in RegularExpressionDxe.inf. > Patch link: https://github.com/shenglei10/edk2/commits/oniguruma > > .../Oniguruma/OnigurumaUefiPort.c |26 - > .../RegularExpressionDxe/Oniguruma/ascii.c| 118 - > .../Oniguruma/onig_init.c |45 - > .../RegularExpressionDxe/Oniguruma/regcomp.c | 6972 > .../RegularExpressionDxe/Oniguruma/regenc.c | 1029 - > .../RegularExpressionDxe/Oniguruma/regerror.c | 402 - > .../RegularExpressionDxe/Oniguruma/regexec.c | 5874 --- > .../RegularExpressionDxe/Oniguruma/reggnu.c | 131 - > .../RegularExpressionDxe/Oniguruma/regparse.c | 8461 - > .../Oniguruma/regposerr.c | 108 - > .../RegularExpressionDxe/Oniguruma/regposix.c | 304 - > .../Oniguruma/regsyntax.c | 336 - > .../RegularExpressionDxe/Oniguruma/regtrav.c |76 - > .../Oniguruma/regversion.c|57 - > .../RegularExpressionDxe/Oniguruma/st.c | 588 - > .../RegularExpressionDxe/Oniguruma/unicode.c | 1152 - > .../Oniguruma/unicode_egcb_data.c | 1374 - > .../Oniguruma/unicode_fold1_key.c | 2995 -- > .../Oniguruma/unicode_fold2_key.c | 222 - > .../Oniguruma/unicode_fold3_key.c | 133 - > .../Oniguruma/unicode_fold_data.c | 1522 - > .../Oniguruma/unicode_property_data.c | 30388 > .../Oniguruma/unicode_property_data_posix.c | 5347 --- > .../Oniguruma/unicode_unfold_key.c| 3299 -- > .../Oniguruma/unicode_wb_data.c | 1023 - > .../RegularExpressionDxe/Oniguruma/utf16_le.c | 309 - > .../{Oniguruma => }/OnigurumaIntrinsics.c | 1 + > .../RegularExpressionDxe/OnigurumaUefiPort.c |90 + > .gitmodules | 3 + > .../RegularExpressionDxe/Oniguruma/AUTHORS| 1 - > .../RegularExpressionDxe/Oniguruma/COPYING|26 - > .../RegularExpressionDxe/Oniguruma/README | 195 - > .../RegularExpressionDxe/Oniguruma/oniggnu.h |87 - > .../Oniguruma/onigposix.h | 172 - > .../Oniguruma/oniguruma.h | 1014 - > .../RegularExpressionDxe/Oniguruma/regenc.h | 279 - > .../RegularExpressionDxe/Oniguruma/regint.h | 1117 - > .../RegularExpressionDxe/Oniguruma/regparse.h | 455 - > .../RegularExpressionDxe/Oniguruma/st.h |69 - > .../{Oniguruma => }/OnigurumaUefiPort.h |44 +- > .../RegularExpressionDxe.h| 3 +- > .../RegularExpressionDxe.inf |73 +- > .../Universal/RegularExpressionDxe/config.h | 9 + > .../Universal/RegularExpressionDxe/oniguruma | 1 + > .../Universal/RegularExpressionDxe/stdarg.h | 9 + > .../Universal/RegularExpressionDxe/stddef.h | 9 + > .../Universal/RegularExpressionDxe/stdio.h| 9 + > .../Universal/RegularExpressionDxe/stdlib.h | 9 + > .../Universal/RegularExpressionDxe/string.h | 9 + > 49 files changed, 230 insertions(+), 75745 deletions(-) > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/OnigurumaUe > fiPort.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/ascii.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/onig_init.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regcomp.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regenc.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regexec.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c > delete mode 100644 > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regparse.c > delete
Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei > Sent: Thursday, April 2, 2020 3:17 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make > oniguruma a submodule in edk2. > > Use submodule way to access oniguruma. And upgrade oniguruma > version from v6.9.3 to v6.9.4_mark1. > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073 > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > > v2:1.Update the inf file to make VS2019 build pass. >2.Add ignore files in MdeModulePkg.ci.yaml. > > The patch is too big, so I put the change on my forked tree. > https://github.com/shenglei10/edk2/tree/oniguruma > > -- > 2.18.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56931): https://edk2.groups.io/g/devel/message/56931 Mute This Topic: https://groups.io/mt/72719780/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.
Use submodule way to access oniguruma. And upgrade oniguruma version from v6.9.3 to v6.9.4_mark1. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073 Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Shenglei Zhang --- v2:1.Update the inf file to make VS2019 build pass. 2.Add ignore files in MdeModulePkg.ci.yaml. The patch is too big, so I put the change on my forked tree. https://github.com/shenglei10/edk2/tree/oniguruma -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56887): https://edk2.groups.io/g/devel/message/56887 Mute This Topic: https://groups.io/mt/72719780/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2.
If no other comments, I will merge this change tomorrow. -Original Message- From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: 2020年3月12日 11:12 To: Zhang, Shenglei ; devel@edk2.groups.io Cc: Wang, Jian J ; Wu, Hao A Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2. Reviewed-by: Liming Gao -Original Message- From: Zhang, Shenglei Sent: 2020年3月9日 15:28 To: devel@edk2.groups.io Cc: Wang, Jian J ; Wu, Hao A ; Gao, Liming Subject: [PATCH v2] MdeModulePkg/RegularExpressionDxe: Make oniguruma a submodule in edk2. Use submodule way to access oniguruma. And upgrade oniguruma version from v6.9.3 to v6.9.4_mark1. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073 Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Shenglei Zhang --- v2: Include wrapper files in RegularExpressionDxe.inf. Patch link: https://github.com/shenglei10/edk2/commits/oniguruma .../Oniguruma/OnigurumaUefiPort.c |26 - .../RegularExpressionDxe/Oniguruma/ascii.c| 118 - .../Oniguruma/onig_init.c |45 - .../RegularExpressionDxe/Oniguruma/regcomp.c | 6972 .../RegularExpressionDxe/Oniguruma/regenc.c | 1029 - .../RegularExpressionDxe/Oniguruma/regerror.c | 402 - .../RegularExpressionDxe/Oniguruma/regexec.c | 5874 --- .../RegularExpressionDxe/Oniguruma/reggnu.c | 131 - .../RegularExpressionDxe/Oniguruma/regparse.c | 8461 - .../Oniguruma/regposerr.c | 108 - .../RegularExpressionDxe/Oniguruma/regposix.c | 304 - .../Oniguruma/regsyntax.c | 336 - .../RegularExpressionDxe/Oniguruma/regtrav.c |76 - .../Oniguruma/regversion.c|57 - .../RegularExpressionDxe/Oniguruma/st.c | 588 - .../RegularExpressionDxe/Oniguruma/unicode.c | 1152 - .../Oniguruma/unicode_egcb_data.c | 1374 - .../Oniguruma/unicode_fold1_key.c | 2995 -- .../Oniguruma/unicode_fold2_key.c | 222 - .../Oniguruma/unicode_fold3_key.c | 133 - .../Oniguruma/unicode_fold_data.c | 1522 - .../Oniguruma/unicode_property_data.c | 30388 .../Oniguruma/unicode_property_data_posix.c | 5347 --- .../Oniguruma/unicode_unfold_key.c| 3299 -- .../Oniguruma/unicode_wb_data.c | 1023 - .../RegularExpressionDxe/Oniguruma/utf16_le.c | 309 - .../{Oniguruma => }/OnigurumaIntrinsics.c | 1 + .../RegularExpressionDxe/OnigurumaUefiPort.c |90 + .gitmodules | 3 + .../RegularExpressionDxe/Oniguruma/AUTHORS| 1 - .../RegularExpressionDxe/Oniguruma/COPYING|26 - .../RegularExpressionDxe/Oniguruma/README | 195 - .../RegularExpressionDxe/Oniguruma/oniggnu.h |87 - .../Oniguruma/onigposix.h | 172 - .../Oniguruma/oniguruma.h | 1014 - .../RegularExpressionDxe/Oniguruma/regenc.h | 279 - .../RegularExpressionDxe/Oniguruma/regint.h | 1117 - .../RegularExpressionDxe/Oniguruma/regparse.h | 455 - .../RegularExpressionDxe/Oniguruma/st.h |69 - .../{Oniguruma => }/OnigurumaUefiPort.h |44 +- .../RegularExpressionDxe.h| 3 +- .../RegularExpressionDxe.inf |73 +- .../Universal/RegularExpressionDxe/config.h | 9 + .../Universal/RegularExpressionDxe/oniguruma | 1 + .../Universal/RegularExpressionDxe/stdarg.h | 9 + .../Universal/RegularExpressionDxe/stddef.h | 9 + .../Universal/RegularExpressionDxe/stdio.h| 9 + .../Universal/RegularExpressionDxe/stdlib.h | 9 + .../Universal/RegularExpressionDxe/string.h | 9 + 49 files changed, 230 insertions(+), 75745 deletions(-) delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/OnigurumaUefiPort.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/ascii.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/onig_init.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regcomp.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regenc.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regerror.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regexec.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regparse.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposerr.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposix.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regsyntax.c delete mode 100644 MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regtrav.c delete mode