That's good. I have no other comment. Reviewed-by: Liming Gao
>-Original Message-
>From: Cheng, Ching JenX
>Sent: Wednesday, September 18, 2019 9:51 AM
>To: Gao, Liming ; devel@edk2.groups.io
>Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
> Subject: RE: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
>
> Ching:
> The change is good. With this change, have you verified VS2017 tool chain?
> I want to make sure there is no impact on VS2017.
>
> Thanks
> Liming
> > -Original Message-
>
ent: Tuesday, September 17, 2019 11:23 AM
> To: devel@edk2.groups.io; Cheng, Ching JenX
> Subject: Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182
>
> In order to support VS2019 on EDK2, the following patches was m
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182
In order to support VS2019 on EDK2, the following patches was modified def and
batch files 1. Add VS2019 x86/64 definitions on tools_def.template 2. Add
VS2019 support on toolsetup batches, and add version check with command vswhere
B
In order to support VS2019 on EDK2, the following patches was modified def and
batch files
1. Add VS2019 x86/64 definitions on tools_def.template
2. Add VS2019 support on toolsetup batches, and add version check with command
vswhere
Because VS2019 and VS2017 using the same vswhere to get the
