Re: [edk2-devel] [PATCH v2 1/1] BaseTools/Capsule: Tool to Generate Windows Firmware Update Driver

2019-06-10 Thread Eric Jin
Bob, Thank for the comments. Will be updated in v2. Best Regards Eric -Original Message- From: Feng, Bob C Sent: Tuesday, June 11, 2019 9:37 AM To: Jin, Eric ; devel@edk2.groups.io Cc: Gao, Liming ; Kinney, Michael D Subject: RE: [PATCH v2 1/1] BaseTools/Capsule: Tool to Generate

Re: [edk2-devel] [PATCH v2 1/1] BaseTools/Capsule: Tool to Generate Windows Firmware Update Driver

2019-06-10 Thread Bob Feng
Hi Eric, There are 2 comments on the code. +if(capture): +outr = PropagatingThread(target=reader, args=(outfile, outstream, c.stdout,)) +outr.start() +outr.join() +c.wait() +else: +c.wait() c.wait() in both "if" and "else" block, I think it

[edk2-devel] [PATCH v2 1/1] BaseTools/Capsule: Tool to Generate Windows Firmware Update Driver

2019-06-02 Thread Eric Jin
https://bugzilla.tianocore.org/show_bug.cgi?id=1837 The tool is designed to generate Windows Firmware Update Drivers, the input is one drivername.cap with related parameters, the output Windows Driver package are composed by drivername.cap, drivername.inf and drivername.cat to update the single