Re: [edk2-devel] [PATCH v2 1/1] MdePkg: UefiLib: Add a function to check if a language is supported

2019-09-02 Thread Tomas Pilar (tpilar)
Hi Liming, I think the very general idea is that UEFI spec requires language based DriverModel protocol members to always check if the language is supported and return EFI_UNSUPPORTED otherwise. The procotols such as ComponentName2, DriverDiagnostics2, etc. usually also publish a member string

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: UefiLib: Add a function to check if a language is supported

2019-09-02 Thread Tom Zhao
Hi Liming The IsLanguageSupported() is intended for use in implementations of UEFI Driver Model protocols. The protocol functions that will likely use this are ones where the specification requires a language check, such as EFI_DRIVER_DIAGNOSTIC2_PROTOCOL.RunDiagnostics(). Currently, to check if

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: UefiLib: Add a function to check if a language is supported

2019-09-01 Thread Liming Gao
Tom: New API IsLanguageSupported() only supports RFC 4646 language code for the Unicode string. If you think ISO 639-2 language code is obsolete, and don't plan to support it any longer. Please update IsLanguageSupported() function description to clarify this API for RFC 4646 language

[edk2-devel] [PATCH v2 1/1] MdePkg: UefiLib: Add a function to check if a language is supported

2019-08-30 Thread Tom Zhao
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2100 Add a function that checks if a target language is in the supported languages list. Refactor UefiLib to use this function where appropriate internally. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Tom Zhao ---