Re: [edk2-devel] [PATCH v2 2/2] ArmPlatformPkg: Fix comparison of constants warning

2020-05-20 Thread Philippe Mathieu-Daudé
[Top-posting is difficult to read on technical lists; it's better to reply inline; maybe GitHub will fix this problem after all] On 5/20/20 1:25 PM, Sami Mujawar wrote: Hi Philippe, I had put a descriptive message to make people aware that the pragma effects the next line of code only. But I

Re: [edk2-devel] [PATCH v2 2/2] ArmPlatformPkg: Fix comparison of constants warning

2020-05-20 Thread Sami Mujawar
Hi Philippe, I had put a descriptive message to make people aware that the pragma effects the next line of code only. But I agree we can abbreviate it as per your suggestion. However, there is an ongoing discussion about an alternative (by which we could avoid the pragma) on another thread at

Re: [edk2-devel] [PATCH v2 2/2] ArmPlatformPkg: Fix comparison of constants warning

2020-05-20 Thread Philippe Mathieu-Daudé
Hi Sami, On 5/18/20 2:46 PM, Sami Mujawar wrote: The VS2017 compiler reports 'warning C6326: potential comparison of a constant with another constant' when a fixed PCD value is compared with a constant value. The faulting code is as marked by '-->' below: --> if (FixedPcdGet32

Re: [edk2-devel] [PATCH v2 2/2] ArmPlatformPkg: Fix comparison of constants warning

2020-05-18 Thread Leif Lindholm
On Mon, May 18, 2020 at 13:46:46 +0100, Sami Mujawar wrote: > The VS2017 compiler reports 'warning C6326: potential > comparison of a constant with another constant' when > a fixed PCD value is compared with a constant value. > > The faulting code is as marked by '-->' below: > > --> if

[edk2-devel] [PATCH v2 2/2] ArmPlatformPkg: Fix comparison of constants warning

2020-05-18 Thread Sami Mujawar
The VS2017 compiler reports 'warning C6326: potential comparison of a constant with another constant' when a fixed PCD value is compared with a constant value. The faulting code is as marked by '-->' below: --> if (FixedPcdGet32 (PL011UartInteger) != 0) { Integer = FixedPcdGet32