Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

; vit9696 ; Gao, Liming ; Gao, Zhichao ; Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions Good day, Unfortunately, this discussion has died again. This is fine by me, I'm also fine with the already proposed patch and mostly shared different

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

t;>>> >>>> As a caller we have now have control: >>>> EFI_STATUS Status; >>>> CHAR16Dst[2]; >>>> >>>> SetConstraintHandler (IgnoreConstraintHandler); >>>> Status = StrCpyS (Dst, sizeof (Dst), L"Too Long&q

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

>>>> goto Label; \ >>>> } \ >>>> } while (FALSE) >>>> >>>> >>>> As a caller we have now have control: >>>> EFI_STATUS Status; >>>> CHAR16        Dst[2]; >>>> >>>> SetC

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

, Marvin Von: Marvin Häuser Gesendet: Montag, 17. Februar 2020 09:26 An: devel@edk2.groups.io; af...@apple.com; Mike Kinney Cc: vit9696; Gao, Liming; Gao, Zhichao; Marvin Häuser; Laszlo Ersek Betreff: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions Good day

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

argue for less typing and more symmetry and >> say use ASSERT, CONSTRAINT, and REQUIRE. I guess you could add >> an ASSERT_ACTION too. >> The AssertMacros.h versions also support _quiet (skip the >> print) and _string (add a string to the print) so you end up wi

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

mailto:liming@intel.com>>; Gao, Zhichao > mailto:zhichao@intel.com>>; Marvin Häuser > mailto:marvin.haeu...@outlook.com>>; Laszlo > Ersek mailto:ler...@redhat.com>> > Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string > constraint

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

It seems that edk2.groups.io has hit the limits for message size due to quotation levels (?), so I send another copy of my previous message to have it visible from the web-interface. Andrew, It is ok, as we are all here for mutual benefit, no worries. But you are right

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

her forms for folks to think about. I'm >> probably biased as I used to looking at code and seeing things like >> require_action_string(Arg1 != NULL, ErrorExit, Status = >> EFI_INVALID_PARAMETER, "1st Arg1 check"); >> >> Thanks, >> >> Andr

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

t;1st Arg1 check"); > > Thanks, > > Andrew Fish > > PS The old debug macros had 2 versions of CONSTRAINT check and verify. The > check version was compiled out on a release build, the verify version always > does the check and just skips the DEBUG print. >

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

nks, > > Mike > > > > From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > mailto:devel@edk2.groups.io>> On Behalf Of Vitaly > Cheptsov via Groups.Io > Sent: Friday, February 14, 2020 3:55 AM > To: Kinney, Michael D <mailto:michael.d.kin...@intel.com>

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

o, Zhichao > ; Marvin Häuser ; Laszlo > Ersek > Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string > constraint assertions > > Michael, > > Generalising the approach makes good sense to me, but we need to make an > obvious distinguishable difference

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

...@intel.com>>; devel@edk2.groups.io > <mailto:devel@edk2.groups.io> > Cc: Marvin Häuser <mailto:marvin.haeu...@outlook.com>>; Laszlo Ersek <mailto:ler...@redhat.com>> > Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string > constrai

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

; Gao, Zhichao ; devel@edk2.groups.io Cc: Marvin Häuser ; Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions Replying as per Liming's request for this to be merged into edk2-stable202002. On Mon, Feb 10, 2020 at 14:12, vit9696

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

pply to all >>> these APIs across all packages. >>> >>> Thanks, >>> >>> Mike >>> >>>> -----Original Message- >>>> From: devel@edk2.groups.io On >>>> Behalf Of Vitaly Cheptsov via Groups.Io >>>&

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

pattern we can potentially apply to all >> these APIs across all packages. >> >> Thanks, >> >> Mike >> >>> -Original Message- >>> From: devel@edk2.groups.io On >>> Behalf Of Vitaly Cheptsov via Groups.Io >>> S

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

Monday, January 6, 2020 10:44 AM >> To: Kinney, Michael D >> Cc: devel@edk2.groups.io >> Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to >> disable safe string constraint assertions >> >> Hi Mike, >> >> Yes, the primary use case is for UE

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

Sent: Monday, January 6, 2020 10:44 AM > To: Kinney, Michael D > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to > disable safe string constraint assertions > > Hi Mike, > > Yes, the primary use case is for UEFI Applications. We > do

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

On Mon, Jan 6, 2020 at 10:43 AM, Vitaly Cheptsov wrote: > > My original suggestion was to remove the assertions entirely, but several > people here said that they use them to verify usage errors when handling > trusted data. This makes good sense to me, so we suggest to support both > cases by

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

vel@edk2.groups.io On >> Behalf Of Vitaly Cheptsov via Groups.Io >> Sent: Friday, January 3, 2020 9:13 AM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH v3 0/1] Add PCD to disable >> safe string constraint assertions >> >> REF: >> h

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

13 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v3 0/1] Add PCD to disable > safe string constraint assertions > > REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > Requesting for merge in edk2-stable202002. > > Changes since V1: >

[edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Requesting for merge in edk2-stable202002. Changes since V1: - Enable assertions by default to preserve the original behaviour - Fix bugzilla reference link - Update documentation in BaseLib.h Vitaly Cheptsov (1): MdePkg: Add PCD to