Re: [edk2-devel] [PATCH v3 6/7] MdeModulePkg/PeCoffImageEmulator: avoid redeclaration of typedef

2019-06-02 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Friday, May 31, 2019 8:50 PM >To: devel@edk2.groups.io >Cc: Ard Biesheuvel ; Laszlo Ersek >; Gao, Liming ; Wang, Jian J >; Leif Lindholm ; Kinney, >Michael D >Subject: [PATCH v3

[edk2-devel] [PATCH v3 6/7] MdeModulePkg/PeCoffImageEmulator: avoid redeclaration of typedef

2019-05-31 Thread Ard Biesheuvel
The usual pattern of defining a protocol in EDK2 is typedef struct _FOO_PROTOCOL FOO_PROTOCOL; struct _FOO_PROTOCOL { ... }; However, in the definition of EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL, we are deviating from this for no good reason, and instead, the struct