Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol

2019-06-13 Thread Wu, Hao A
> -Original Message- > From: Yao, Jiewen > Sent: Friday, June 14, 2019 6:32 AM > To: Zurcher, Christopher J; Gao, Liming; devel@edk2.groups.io > Cc: Kinney, Michael D; Wang, Jian J; Ni, Ray; Wu, Hao A > Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security Command > Protocol >

Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol

2019-06-13 Thread Yao, Jiewen
Thank you Christopher. Your code looks good to me. I also recommend MdeModulePkg/SCSI owner take a look and give r-b. Ray or Hao Can you help on that? Thank you Yao Jiewen > -Original Message- > From: Zurcher, Christopher J > Sent: Friday, June 14, 2019 6:26 AM > To: Gao, Liming ; devel

Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol

2019-06-13 Thread Zurcher, Christopher J
A unit test has been run which provisions RPMB key, writes data, and verifies it after reading on the following boot. Further, this code is being exercised for secure storage on multiple platforms as part of standard boot flow. Unit test files emailed separately. Thanks, Christopher Zurcher -

Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol

2019-06-13 Thread Liming Gao
Zurcher: Can you share what test has been done for this feature? Thanks Liming > -Original Message- > From: Zurcher, Christopher J > Sent: Thursday, June 13, 2019 10:05 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen > ; Wang, Jian J ; Gao, > Liming > Subject: [PATC

[edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol

2019-06-12 Thread Zurcher, Christopher J
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 V4 changes: Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. Add error handling for (BlockSize == 0) in Read and WriteBlocks commands to handle partitions that do not support ReadCapacity(). V3 changes: Initialize Alig