Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0
HI Zhichao, I revise it as your suggestion. [PATCH v6] for the third patch (rebased) was just sent. Thanks Abner > -Original Message- > From: Gao, Zhichao [mailto:zhichao@intel.com] > Sent: Wednesday, October 9, 2019 10:58 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Carsey, Jaben ; Ni, Ray ; > Leif Lindholm ; Chen, Gilbert > > Subject: RE: [edk2-devel] [PATCH v5 3/3] > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 > > How about change the function name from ProcessorArchitectureType to > DisplayProcessorArchitectureType? > > And why separate the processor arch type display into two section: > i.e. first display " ProcessorSpecificBlock.ProcessorArchType: 0xXX" thru > PRINT_STRUCT_VALUE_H, second display the value's meaning thru > ProcessorArchitectureType, such as " 128-bit RISC-V (RV128)". > I suggest to put them into one function DisplayProcessorArchitectureType > like other functions did. Such as the blowing format: > VOID > DisplayMCHostInterfaceType ( > IN UINT8 Key, > IN UINT8 Option > ) > { > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > (STR_SMBIOSVIEW_QUERYTABLE_MC_HOST_INTERFACE_TYPE), > gShellDebug1HiiHandle); > PRINT_INFO_OPTION (Key, Option); > PRINT_TABLE_ITEM (MCHostInterfaceTypeTable, Key); } > > Thanks, > Zhichao > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Abner Chang > > Sent: Tuesday, October 8, 2019 4:04 PM > > To: devel@edk2.groups.io > > Cc: abner.ch...@hpe.com; Carsey, Jaben ; Ni, > > Ray ; Gao, Zhichao ; Leif > > Lindholm ; Gilbert Chen > > > > Subject: [edk2-devel] [PATCH v5 3/3] > > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 > > > > Shell command smbiosview updates for SMBIOS 3.3.0 spec. > > > > Bugzilla link, > > INVALID URI REMOVED > > e.org_show-5Fbug.cgi-3Fid- > 3D2202=DwIFAg=C5b8zRQO1miGmBeVZ2LFWg=_ > > > SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E=iZPRGBE2YqYcm2VO > KgWvwrtGD > > P3Gn- > 0WwIs5VAkpqao=SidItX73peVBmSm4Ws1A5kr8hOtp2MBpWKg4zdb4Jeg& > e= > > > > Signed-off-by: Abner Chang > > > > Cc: Jaben Carsey > > Cc: Ray Ni > > Cc: Zhichao Gao > > Cc: Leif Lindholm > > Cc: Gilbert Chen > > --- > > .../SmbiosView/PrintInfo.c | 23 +++- > > .../SmbiosView/PrintInfo.h | 13 - > > .../SmbiosView/QueryTable.c| 63 > > +- > > .../UefiShellDebug1CommandsLib.uni | 3 +- > > 4 files changed, 98 insertions(+), 4 deletions(-) > > > > diff --git > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > index cfd7a2b..ff0c1db 100644 > > --- > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > +++ > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > @@ -3,7 +3,7 @@ > > > >Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved. > >(C) Copyright 2014 Hewlett-Packard Development Company, L.P. > > - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development > > LP > > + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development > > + LP > >SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( > > break; > > > >// > > + // Processor Additional Information (Type 44) // case 44: > > +PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); > > +PRINT_STRUCT_VALUE_H (Struct, Type44, > > ProcessorSpecificBlock.ProcessorArchType); > > +ProcessorArchitectureType (Struct->Type44- > > >ProcessorSpecificBlock.ProcessorArchType, Option); > > +break; > > + > > + // > >// Inactive (Type 126) > >// > >case 126: > > @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( > >Print (L"Video Processor\n"); > >break; > > > > +case 0x200: > > + Print (L"RISC-V RV32\n"); > > + break; > > + > > +case 0x201: > > + Print (L"RISC-V RV64\n"); > > + break; > > + > > +case 0x202: > > + Print (L"RISC-V RV128\n"); > > + break; > > + > > default: > > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > > (STR_
Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0
How about change the function name from ProcessorArchitectureType to DisplayProcessorArchitectureType? And why separate the processor arch type display into two section: i.e. first display " ProcessorSpecificBlock.ProcessorArchType: 0xXX" thru PRINT_STRUCT_VALUE_H, second display the value's meaning thru ProcessorArchitectureType, such as " 128-bit RISC-V (RV128)". I suggest to put them into one function DisplayProcessorArchitectureType like other functions did. Such as the blowing format: VOID DisplayMCHostInterfaceType ( IN UINT8 Key, IN UINT8 Option ) { ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_QUERYTABLE_MC_HOST_INTERFACE_TYPE), gShellDebug1HiiHandle); PRINT_INFO_OPTION (Key, Option); PRINT_TABLE_ITEM (MCHostInterfaceTypeTable, Key); } Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Tuesday, October 8, 2019 4:04 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Carsey, Jaben ; Ni, > Ray ; Gao, Zhichao ; Leif > Lindholm ; Gilbert Chen > Subject: [edk2-devel] [PATCH v5 3/3] > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 > > Shell command smbiosview updates for SMBIOS 3.3.0 spec. > > Bugzilla link, > https://bugzilla.tianocore.org/show_bug.cgi?id=2202 > > Signed-off-by: Abner Chang > > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Leif Lindholm > Cc: Gilbert Chen > --- > .../SmbiosView/PrintInfo.c | 23 +++- > .../SmbiosView/PrintInfo.h | 13 - > .../SmbiosView/QueryTable.c| 63 > +- > .../UefiShellDebug1CommandsLib.uni | 3 +- > 4 files changed, 98 insertions(+), 4 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index cfd7a2b..ff0c1db 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -3,7 +3,7 @@ > >Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved. >(C) Copyright 2014 Hewlett-Packard Development Company, L.P. > - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP > + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP >SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( > break; > >// > + // Processor Additional Information (Type 44) // case 44: > +PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); > +PRINT_STRUCT_VALUE_H (Struct, Type44, > ProcessorSpecificBlock.ProcessorArchType); > +ProcessorArchitectureType (Struct->Type44- > >ProcessorSpecificBlock.ProcessorArchType, Option); > +break; > + > + // >// Inactive (Type 126) >// >case 126: > @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( >Print (L"Video Processor\n"); >break; > > +case 0x200: > + Print (L"RISC-V RV32\n"); > + break; > + > +case 0x201: > + Print (L"RISC-V RV64\n"); > + break; > + > +case 0x202: > + Print (L"RISC-V RV128\n"); > + break; > + > default: > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), > gShellDebug1HiiHandle); >} > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > index a8c32ab..22f59d6 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > @@ -2,7 +2,7 @@ >Module to clarify the element info of the smbios structure. > >Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved. > - (C) Copyright 2017 Hewlett Packard Enterprise Development LP > + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development > + LP >SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( >IN UINT8 Option >); > > +/** > + Display Processor Architecture Type (Type 44). > + > + @param[in] Type The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +ProcessorArchitectureType ( > + IN UINT8 Type, > + IN UINT8 Option > + ); > #endif > diff --git > a/ShellPkg/Library/UefiShell
Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Abner Chang [mailto:abner.ch...@hpe.com] > Sent: Tuesday, October 08, 2019 1:04 AM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Carsey, Jaben ; Ni, > Ray ; Gao, Zhichao ; Leif > Lindholm ; Gilbert Chen > Subject: [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to > support SmBios 3.3.0 > > Shell command smbiosview updates for SMBIOS 3.3.0 spec. > > Bugzilla link, > https://bugzilla.tianocore.org/show_bug.cgi?id=2202 > > Signed-off-by: Abner Chang > > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Leif Lindholm > Cc: Gilbert Chen > --- > .../SmbiosView/PrintInfo.c | 23 +++- > .../SmbiosView/PrintInfo.h | 13 - > .../SmbiosView/QueryTable.c| 63 > +- > .../UefiShellDebug1CommandsLib.uni | 3 +- > 4 files changed, 98 insertions(+), 4 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index cfd7a2b..ff0c1db 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -3,7 +3,7 @@ > >Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved. >(C) Copyright 2014 Hewlett-Packard Development Company, L.P. > - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP > + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP >SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( > break; > >// > + // Processor Additional Information (Type 44) > + // > + case 44: > +PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); > +PRINT_STRUCT_VALUE_H (Struct, Type44, > ProcessorSpecificBlock.ProcessorArchType); > +ProcessorArchitectureType (Struct->Type44- > >ProcessorSpecificBlock.ProcessorArchType, Option); > +break; > + > + // >// Inactive (Type 126) >// >case 126: > @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( >Print (L"Video Processor\n"); >break; > > +case 0x200: > + Print (L"RISC-V RV32\n"); > + break; > + > +case 0x201: > + Print (L"RISC-V RV64\n"); > + break; > + > +case 0x202: > + Print (L"RISC-V RV128\n"); > + break; > + > default: > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), > gShellDebug1HiiHandle); >} > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > index a8c32ab..22f59d6 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > @@ -2,7 +2,7 @@ >Module to clarify the element info of the smbios structure. > >Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved. > - (C) Copyright 2017 Hewlett Packard Enterprise Development LP > + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development LP >SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( >IN UINT8 Option >); > > +/** > + Display Processor Architecture Type (Type 44). > + > + @param[in] Type The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +ProcessorArchitectureType ( > + IN UINT8 Type, > + IN UINT8 Option > + ); > #endif > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > index bfb7c3b..54e9a52 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > @@ -3,7 +3,7 @@ >And give a interface of query a string out of a table. > >Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved. > - (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP > + (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP >SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = { >{ > 7, > L" Power/Performance Control" > + }, > + { > +8, > +L" 128-bit Capable" >} > }; > > @@ -3268,6 +3272,44 @@ TABLE_ITEM MCHostInterfaceTypeTable[] = { >}, > }; > > +TABLE_ITEM ProcessorArchitectureTypesTable[] = { > + { > +0, > +L" Reserved " > + }, > + { > +1, > +L" IA32 (x86) " > + }, > + { > +2, > +L" x64 (x86-64, intel64, AMD64, EM64T) " > + }, > + { > +3, > +L" Intel Itanium architecture " > + }, >
[edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0
Shell command smbiosview updates for SMBIOS 3.3.0 spec. Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Signed-off-by: Abner Chang Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Cc: Leif Lindholm Cc: Gilbert Chen --- .../SmbiosView/PrintInfo.c | 23 +++- .../SmbiosView/PrintInfo.h | 13 - .../SmbiosView/QueryTable.c| 63 +- .../UefiShellDebug1CommandsLib.uni | 3 +- 4 files changed, 98 insertions(+), 4 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index cfd7a2b..ff0c1db 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -3,7 +3,7 @@ Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved. (C) Copyright 2014 Hewlett-Packard Development Company, L.P. - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( break; // + // Processor Additional Information (Type 44) + // + case 44: +PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); +PRINT_STRUCT_VALUE_H (Struct, Type44, ProcessorSpecificBlock.ProcessorArchType); +ProcessorArchitectureType (Struct->Type44->ProcessorSpecificBlock.ProcessorArchType, Option); +break; + + // // Inactive (Type 126) // case 126: @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( Print (L"Video Processor\n"); break; +case 0x200: + Print (L"RISC-V RV32\n"); + break; + +case 0x201: + Print (L"RISC-V RV64\n"); + break; + +case 0x202: + Print (L"RISC-V RV128\n"); + break; + default: ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle); } diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h index a8c32ab..22f59d6 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h @@ -2,7 +2,7 @@ Module to clarify the element info of the smbios structure. Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved. - (C) Copyright 2017 Hewlett Packard Enterprise Development LP + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development LP SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( IN UINT8 Option ); +/** + Display Processor Architecture Type (Type 44). + + @param[in] Type The key of the structure. + @param[in] Option The optional information. +**/ +VOID +ProcessorArchitectureType ( + IN UINT8 Type, + IN UINT8 Option + ); #endif diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c index bfb7c3b..54e9a52 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c @@ -3,7 +3,7 @@ And give a interface of query a string out of a table. Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved. - (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP + (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = { { 7, L" Power/Performance Control" + }, + { +8, +L" 128-bit Capable" } }; @@ -3268,6 +3272,44 @@ TABLE_ITEM MCHostInterfaceTypeTable[] = { }, }; +TABLE_ITEM ProcessorArchitectureTypesTable[] = { + { +0, +L" Reserved " + }, + { +1, +L" IA32 (x86) " + }, + { +2, +L" x64 (x86-64, intel64, AMD64, EM64T) " + }, + { +3, +L" Intel Itanium architecture " + }, + { +4, +L" 32-bit ARM (Aarch32) " + }, + { +5, +L" 64-bit ARM (Aarch64) " + }, + { +6, +L" 32-bit RISC-V (RV32) " + }, + { +7, +L" 64-bit RISC-V (RV64) " + }, + { +8, +L" 128-bit RISC-V (RV128) " + } +}; TABLE_ITEM StructureTypeInfoTable[] = { { @@ -3447,6 +3489,10 @@ TABLE_ITEM StructureTypeInfoTable[] = { L" TPM Device" }, { +44, +L" Processor Additional Information" + }, + { 0x7E, L" Inactive" }, @@ -4697,6 +4743,21 @@ DisplayMCHostInterfaceType ( } /** + Display Processor Architecture Type (Type 44). + + @param[in] Type The key of the structure. + @param[in] Option The