Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

2020-02-03 Thread Michael D Kinney
0 2:04 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Mathews, John > ; Sukerkar, Amol N > > Subject: RE: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib

Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

2020-02-03 Thread Sukerkar, Amol N
, Sachin ; Musti, Srinivas ; Lakkimsetti, Subash ; Mathews, John Subject: RE: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Amol, One additional issue was found by the Linux/GCC build. The lib class .h file was correct, but I missed that the context

Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

2020-02-03 Thread Sukerkar, Amol N
; Lakkimsetti, Subash ; Mathews, John Subject: RE: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Hi Amol, I prepared a branch an GitHub PR with this content. The EDK II CI checks found duplicate GUID issues: PROGRESS - --Running CryptoPkg: Guid

Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

2020-02-03 Thread Michael D Kinney
gt; ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Mathews, John > ; Sukerkar, Amol N > > Subject: RE: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > Thanks for the review, Mike! > >

Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

2020-02-03 Thread Sukerkar, Amol N
; Lakkimsetti, Subash ; Mathews, John Subject: Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Hi Amol, Thanks for the updates. They all look great. Series Reviewed-by: Michael D Kinney Mike > -Original Message- > From: deve

Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

2020-02-03 Thread Michael D Kinney
Michael D ; > Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Mathews, John > > Subject: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > Currently, the UEFI drivers us

[edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

2020-02-03 Thread Sukerkar, Amol N
Currently, the UEFI drivers using the SHA/SM3 hashing algorithms use hard-coded API to calculate the hash, for instance, sha_256(...), etc. Since SHA384 and/or SM3_256 are being increasingly adopted for robustness, it becomes cumbersome to modify each driver that calls into hash calculating API.