Pushed at df43ea6c08100487776bb0962c657d214e345ae7
Thanks,
Bob
-Original Message-
From: Kinney, Michael D
Sent: Thursday, August 29, 2019 2:40 AM
To: Gao, Liming ; Feng, Bob C ;
devel@edk2.groups.io; Kinney, Michael D
Cc: Shi, Steven ; af...@apple.com; Laszlo Ersek
(ler...@redhat.com)
Liming,
I can no longer reproduce the issues I noted below.
I agree this is a critical regression issue that must
be fixed for the edk2-stable201908 release.
Tested-by: Michael D Kinney
Acked-by: Michael D Kinney
Thanks,
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: We
Liming,
I set up a fresh environment and I now see the expected behavior when
modifying INF files with this patch applied. I can not reproduce the issues
I saw earlier today.
I will continue to do some more testing before I provide a Tested-by.
Mike
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: Yo
Liming,
This fix does not look complete to me.
I applied this patch and used FatPkg as a test.
I modified FatPkg/EnhancedFatDxe/Fat.inf removing
Defines, Source files, Library Classes, GUID, Protocols,
and PCDs and it never rebuilds the module.
If I remove the BASE_NAME define, I get a stack t
Mike:
I add notes in BZ. Current problem is that the change in INF file will not
trig rebuild. For example:
1st build:
build -p MdeModulePkg\MdeModulePkg.dsc -a IA32 -m
MdeModulePkg\Application\HelloWorld\HelloWorld.inf
2st build with below change
update MdeModulePkg\Application\HelloWorld\H
Bob and Liming,
What is an example test case that fails? Please add to BZ.
We need this information to test that this fix resolves the
issue.
Mike
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, August 28, 2019 8:26 AM
> To: Feng, Bob C ;
> devel@edk2.groups.io
> Cc: Shi, S
Bob:
This is the critical regression issue for the incremental build. I request to
catch it in this stable tag 201908.
This patch corrects the behavior. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, August 28, 2019 4:52 PM
> To:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2137
This patch is going to fix a regression issue of incremental
build which was introduced by the commit 94459080c.
The changing on INF file will not trigger module rebuild.
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Steven Shi
---
BaseTool
