Re: [edk2-devel] [Patch] BaseTools/Scripts/PatchCheck: Address false error conditions

2020-01-14 Thread Laszlo Ersek
On 01/13/20 19:38, Kinney, Michael D wrote: > Hi Laszlo, > > This patch has been pushed. > > https://github.com/tianocore/edk2/pull/297 > > I also entered a new BZ to relax CVE pattern check. > > https://bugzilla.tianocore.org/show_bug.cgi?id=2462 Thank you for both! Laszlo

Re: [edk2-devel] [Patch] BaseTools/Scripts/PatchCheck: Address false error conditions

2020-01-13 Thread Michael D Kinney
ek > Sent: Monday, January 13, 2020 9:32 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Justen, Jordan L > > Subject: Re: [edk2-devel] [Patch] > BaseTools/Scripts/PatchCheck: Address false error > conditions > > He

Re: [edk2-devel] [Patch] BaseTools/Scripts/PatchCheck: Address false error conditions

2020-01-13 Thread Laszlo Ersek
Hello Mike, thanks a lot for this patch! Comments below: On 01/10/20 23:53, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=2406 > > * Always print subject line after the git commit id to make > it easier to know the context of warnings or errors. > * Allow UTF-8

Re: [edk2-devel] [Patch] BaseTools/Scripts/PatchCheck: Address false error conditions

2020-01-12 Thread Bob Feng
Hi Mike, This patch can't apply to edk2 repo, please update. For this patch, Reviewed-by: Bob Feng Thanks, Bob -Original Message- From: Kinney, Michael D Sent: Saturday, January 11, 2020 6:54 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Laszlo Ersek ; Justen, Jordan

[edk2-devel] [Patch] BaseTools/Scripts/PatchCheck: Address false error conditions

2020-01-10 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2406 * Always print subject line after the git commit id to make it easier to know the context of warnings or errors. * Allow UTF-8 characters in subject line * Error if subject line length > 75 without CVE-xxx-x present * Error if subject line