Re: [edk2-devel] [Patch] BaseTools: Remove invalid leading space before !INCLUDE in Makefile

2020-03-01 Thread Bob Feng
; Kinney, Michael D ; Pierre Gondois Subject: RE: [edk2-devel] [Patch] BaseTools: Remove invalid leading space before !INCLUDE in Makefile Reviewed-by: Liming Gao Tested-by: Liming Gao -Original Message- > From: devel@edk2.groups.io On Behalf Of Bob > Feng > Sent: Thursday, Fe

Re: [edk2-devel] [Patch] BaseTools: Remove invalid leading space before !INCLUDE in Makefile

2020-02-27 Thread Liming Gao
; ; Pierre Gondois > Subject: [edk2-devel] [Patch] BaseTools: Remove invalid leading space before > !INCLUDE in Makefile > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2563 > > This patch is to fix a incremental build regression bug > which happen when using n

[edk2-devel] [Patch] BaseTools: Remove invalid leading space before !INCLUDE in Makefile

2020-02-27 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2563 This patch is to fix a incremental build regression bug which happen when using nmake. That's introduced by 818283de3f6d. If there is white space before !INCLUDE instruction, nmake will not process it. Source code's dependent header files