Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-12 Thread Liming Gao
Laszlo: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, October 11, 2019 5:37 PM >To: Gao, Liming >Cc: Andrew Fish ; devel@edk2.groups.io; Tom Lendacky > >Subject: Re: [edk2-devel] [Patc

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-11 Thread Laszlo Ersek
>>>> Sent: Thursday, October 10, 2019 3:35 PM >>>> To: Andrew Fish ; Gao, Liming >>>> Cc: devel@edk2.groups.io >>>> Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool >> chain - >>>> >>>> Hi Andrew, >>

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-11 Thread Laszlo Ersek
Hi Liming, On 10/09/19 16:44, Gao, Liming wrote: > The difference between XCODE/CLANG and GCCXX is the linker. Current > patches are introduced for the different linker. Clang supports most > usage of GCC compiler. So, CLANG and XCODE uses GCC family. When I > enable XCODE or CLANG tool chain in

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Liming Gao
Laszlo: >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, October 11, 2019 12:43 AM >To: devel@edk2.groups.io; Gao, Liming ; Andrew Fish > >Cc: Justen, Jordan L >Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Laszlo Ersek
Hi Liming, On 10/10/19 14:18, Liming Gao wrote: >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Thursday, October 10, 2019 3:35 PM >> To: Andrew Fish ; Gao, Liming >> Cc: devel@edk2.groups.io >> Subject: Re

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-10 Thread Andrew Fish via Groups.Io
10, 2019, at 5:18 AM, Gao, Liming wrote: > > > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Thursday, October 10, 2019 3:35 PM >> To: Andrew Fish ; Gao, Liming >> Cc: devel@edk2.groups.io >> Sub

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Liming Gao
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, October 10, 2019 3:35 PM > To: Andrew Fish ; Gao, Liming > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain - > >

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Laszlo Ersek
Hi Andrew, On 10/09/19 18:22, Andrew Fish wrote: > I thought the thing we were discussing was compiler flags. > Specifically -mno-mmx -mno-sse. It seems to me if OVMF requires > -mno-mmx -mno-sse then it is a bug in the tools_def.txt definition > for those compilers? As far as I can tell -mno-im

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-09 Thread Andrew Fish via Groups.Io
> On Oct 9, 2019, at 7:44 AM, Gao, Liming wrote: > > Laszlo: > >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, October 9, 2019 9:44 PM >> To: Andrew Fish ; devel@edk2.groups.io >> Cc: Gao, Liming >> Subject: Re: [edk2-

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-09 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 9:44 PM > To: Andrew Fish ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain > > On 10/09/19 01:08, Andrew

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-09 Thread Laszlo Ersek
On 10/09/19 01:08, Andrew Fish wrote: > So I guess the way to describe it is XCODE inherits GCC and only needs to > override when it is different. Thank you for the explanation! I've been trying to figure out why this inheritance bothers me so much. I guess the reason is the following: I'm a u

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-08 Thread Laszlo Ersek
On 10/08/19 17:02, Gao, Liming wrote: > Laszlo: > >> -Original Message- >> From: Laszlo Ersek >> Sent: Tuesday, October 1, 2019 4:42 AM >> To: devel@edk2.groups.io; Gao, Liming >> Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool c

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-08 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, October 1, 2019 4:42 AM > To: devel@edk2.groups.io; Gao, Liming > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain > > Hi Liming, > > On 09/27/19 09:46, Liming Gao

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-09-30 Thread Laszlo Ersek
Hi Liming, On 09/27/19 09:46, Liming Gao wrote: > 1. Apply CLANG9 Linker option. I'm confused by this, in two regards. - Why do we refer to CLANG9 first as being in the GCC toolchain family (see near mmx/sse), and then under a totally different family name (CLANGPE?) - Regarding the CLANGPE opt

[edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-09-27 Thread Liming Gao
1. Apply CLANG9 Linker option. 2. Add -mno-mmx -mno-sse compiler option Signed-off-by: Liming Gao --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- OvmfPkg/OvmfPkgX64.dsc | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/OvmfPkgIa32.