Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file

2019-10-31 Thread Laszlo Ersek
On 10/30/19 03:27, Leif Lindholm wrote: > On Tue, Oct 29, 2019 at 12:54:58PM -0700, Michael D Kinney wrote: >> From: Sean Brogan >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=2315 >> >> Add pip requirements file that is used to install the >> python pip modules build from the

Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file

2019-10-31 Thread Sean via Groups.Io
I tested using "#" character to indicate the line was a comment.  I did this for a copyright, license identifier, and some text.  On Windows pip -r had no issues installing, upgrading, or uninstalling and didn't show any output related to those lines. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file

2019-10-30 Thread Leif Lindholm
> The pip modules are not only use in a CI agent. > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On > > Behalf Of Leif Lindholm > > Sent: Tuesday, October 29, 2019 8:03 PM > > To: devel@edk2.groups.io; sean.bro...@microsoft.com > &g

Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file

2019-10-30 Thread Michael D Kinney
devel@edk2.groups.io On > Behalf Of Leif Lindholm > Sent: Tuesday, October 29, 2019 8:03 PM > To: devel@edk2.groups.io; sean.bro...@microsoft.com > Subject: Re: [edk2-devel] [Patch v3 03/22] > requirements.txt: Add python pip requirements file > > OK, if it makes a differe

Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file

2019-10-29 Thread Leif Lindholm
OK, if it makes a difference for tools (and security updates), let's try to keep it. (*grumble*) *But* given its too-generic name, can we add a big bold comment header to the file explaining what it is? Some quick searching suggests lines starting with # are ignored, so hopefully this should be

Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file

2019-10-29 Thread Sean via Groups.Io
It is a convention for projects using python.  It definitely isn't required but there are some features that come for free when using that filename. https://github.blog/2018-07-12-security-vulnerability-alerts-for-python/ and

Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file

2019-10-29 Thread Leif Lindholm
On Tue, Oct 29, 2019 at 12:54:58PM -0700, Michael D Kinney wrote: > From: Sean Brogan > > https://bugzilla.tianocore.org/show_bug.cgi?id=2315 > > Add pip requirements file that is used to install the > python pip modules build from the edk2-pytool-library and > edk2-pytool-extensions

[edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file

2019-10-29 Thread Michael D Kinney
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2315 Add pip requirements file that is used to install the python pip modules build from the edk2-pytool-library and edk2-pytool-extensions repositories. These python modules provide the extensions required to perform EDK II