Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

2020-05-20 Thread Laszlo Ersek
On 05/20/20 05:11, Michael D Kinney wrote: > From: Vitaly Cheptsov > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > Runtime checks returned via status return code should not work as > assertions to permit parsing not trusted data with SafeString > interfaces. Replace ASSERT()

Re: [EXTERNAL] Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

2020-05-20 Thread Bret Barkelew via groups.io
;; Yao, Jiewen<mailto:jiewen@intel.com> Subject: [EXTERNAL] Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks Mike, Looks perfect to me. For everyone: the only change from V7 is an addition of DEBUG_VERBOSE message, which can indeed be use

Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

2020-05-20 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, May 20, 2020 11:01 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ard Biesheuvel > ; Bret Barkelew ; > Brian J . Johnson ; Chiu, Chasel > ; Justen, Jordan L ; > Laszlo Ersek ; Leif Lindholm ;

Re: [edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

2020-05-19 Thread Vitaly Cheptsov via groups.io
Mike, Looks perfect to me. For everyone: the only change from V7 is an addition of DEBUG_VERBOSE message, which can indeed be useful. Best wishes, Vitaly > 20 мая 2020 г., в 06:01, Michael D Kinney > написал(а): > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > Runtime

[edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

2020-05-19 Thread Michael D Kinney
From: Vitaly Cheptsov REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Runtime checks returned via status return code should not work as assertions to permit parsing not trusted data with SafeString interfaces. Replace ASSERT() with a DEBUG_VERBOSE message. Cc: Andrew Fish Cc: Ard

[edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

2020-05-19 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Runtime checks returned via status return code should not work as assertions to permit parsing not trusted data with SafeString interfaces. Replace ASSERT() with a DEBUG_VERBOSE message. Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Bret