Re: [edk2-devel] [edk2-non-osi patch 1/1] SimicsICH10SiliconBinPkg: Add UNDI ROM for SIMICS QSP Platform

2019-08-15 Thread Nate DeSimone
Hi David, Please add an .inf file to make it convenient for the platform code to include this binary. Please see the following for an example: edk2-non-osi/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf Also, please add the Maintainers.txt entries and change the package name per my previous

Re: [edk2-devel] [edk2-non-osi patch 1/1] SimicsICH10SiliconBinPkg: Add UNDI ROM for SIMICS QSP Platform

2019-08-12 Thread Nate DeSimone
Hi David, I would prefer if we follow Pascal casing and rename this package to SimicsIch10SiliconBinPkg (instead of SimicsICH10SiliconBinPkg). Also, I think it would be good if we can also add owners for the new packages to the Maintainers.txt file. (SimicsIch10SiliconBinPkg, SimicsX58SktPkg,

[edk2-devel] [edk2-non-osi patch 1/1] SimicsICH10SiliconBinPkg: Add UNDI ROM for SIMICS QSP Platform

2019-08-09 Thread David Wei
Add UNDI option ROM for SIMICS QSP Network support Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei ---

[edk2-devel] [edk2-non-osi patch 1/1] SimicsICH10SiliconBinPkg: Add UNDI ROM for SIMICS QSP Platform

2019-08-09 Thread David Wei
Add UNDI option ROM for SIMICS QSP Network support Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei --- .../UndiBinary/GigUndiDxe.efi