Re: [edk2-devel] [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
Actually we didn't do that. SmbiosBasic.h is only used by c files in its directory and not used in other packages. Thanks, Shenglei > -Original Message- > From: Chaganty, Rangasai V > Sent: Saturday, August 24, 2019 2:12 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Gao, Liming > > Subject: RE: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a > missing header file in INF > > Have you tried adding the path in AdvancedFeaturePkg.dec under [Includes] > section? > > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, August 21, 2019 1:01 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing > header file in INF > > The header file is used but missing in INF,which causes warning message when > building them. > https://bugzilla.tianocore.org/show_bug.cgi?id=2037 > > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD > xe.inf > b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD > xe.inf > index 69e930dd..bbac1d5c 100644 > --- > a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD > xe.inf > +++ > b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi > +++ cDxe.inf > @@ -23,6 +23,7 @@ > > [Sources] >SmbiosBasicEntryPoint.c > + SmbiosBasic.h >Type0BiosVendorFunction.c >Type1SystemManufacturerFunction.c >Type2BaseBoardManufacturerFunction.c > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46393): https://edk2.groups.io/g/devel/message/46393 Mute This Topic: https://groups.io/mt/32976202/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
Have you tried adding the path in AdvancedFeaturePkg.dec under [Includes] section? -Original Message- From: Zhang, Shenglei Sent: Wednesday, August 21, 2019 1:01 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF The header file is used but missing in INF,which causes warning message when building them. https://bugzilla.tianocore.org/show_bug.cgi?id=2037 Cc: Michael Kubacki Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf index 69e930dd..bbac1d5c 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf +++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi +++ cDxe.inf @@ -23,6 +23,7 @@ [Sources] SmbiosBasicEntryPoint.c + SmbiosBasic.h Type0BiosVendorFunction.c Type1SystemManufacturerFunction.c Type2BaseBoardManufacturerFunction.c -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46323): https://edk2.groups.io/g/devel/message/46323 Mute This Topic: https://groups.io/mt/32976202/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
Please extend the copyright date in SmbiosDxe.inf to 2019. With that change: Reviewed-by: Michael Kubacki > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, August 21, 2019 1:01 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing > header file in INF > > The header file is used but missing in INF,which causes warning message when > building them. > https://bugzilla.tianocore.org/show_bug.cgi?id=2037 > > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx > e.inf > b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx > e.inf > index 69e930dd..bbac1d5c 100644 > --- > a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx > e.inf > +++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi > +++ cDxe.inf > @@ -23,6 +23,7 @@ > > [Sources] >SmbiosBasicEntryPoint.c > + SmbiosBasic.h >Type0BiosVendorFunction.c >Type1SystemManufacturerFunction.c >Type2BaseBoardManufacturerFunction.c > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46320): https://edk2.groups.io/g/devel/message/46320 Mute This Topic: https://groups.io/mt/32976202/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
The header file is used but missing in INF,which causes warning message when building them. https://bugzilla.tianocore.org/show_bug.cgi?id=2037 Cc: Michael Kubacki Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf index 69e930dd..bbac1d5c 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf +++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf @@ -23,6 +23,7 @@ [Sources] SmbiosBasicEntryPoint.c + SmbiosBasic.h Type0BiosVendorFunction.c Type1SystemManufacturerFunction.c Type2BaseBoardManufacturerFunction.c -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46137): https://edk2.groups.io/g/devel/message/46137 Mute This Topic: https://groups.io/mt/32976202/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
