Re: [edk2-devel] [edk2-platforms:PATCH] Intel/IntelSiliconPkg Implement SmmAccess in IntelSiliconPkg

2019-08-24 Thread Marc W Chen
August 24, 2019 5:03 AM > To: Chaganty, Rangasai V ; Chen, Marc W > ; devel@edk2.groups.io > Subject: RE: [edk2-platforms:PATCH] Intel/IntelSiliconPkg Implement > SmmAccess in IntelSiliconPkg > > It's not recommended to make IntelSiliconPkg depend on MdeModulePkg. > > >

Re: [edk2-devel] [edk2-platforms:PATCH] Intel/IntelSiliconPkg Implement SmmAccess in IntelSiliconPkg

2019-08-23 Thread Ni, Ray
It's not recommended to make IntelSiliconPkg depend on MdeModulePkg. > -Original Message- > From: Chaganty, Rangasai V > Sent: Friday, August 23, 2019 11:34 AM > To: Chen, Marc W ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: RE: [edk2-platforms:PATCH] Intel/IntelSiliconPkg Implement

Re: [edk2-devel] [edk2-platforms:PATCH] Intel/IntelSiliconPkg Implement SmmAccess in IntelSiliconPkg

2019-08-23 Thread Chaganty, Rangasai V
May I know the reason to implement the SmmAccessLib instance under \Feature folder? Can we move it under IntelSiliconPkg\Library (We need to create a library folder in the root) and keep just the module in the \Feature folder? I've noticed there is a dependency on MdeModulePkg with this change.

[edk2-devel] [edk2-platforms:PATCH] Intel/IntelSiliconPkg Implement SmmAccess in IntelSiliconPkg

2019-08-23 Thread Marc W Chen
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2121 Implement SmmAccess for PEI and DXE phase in IntelSiliconPkg Signed-off-by: Marc Chen Cc: Ray Ni Cc: Rangasai V Chaganty --- .../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 343 +