Re: [edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-27 Thread Chiu, Chasel
Sorry that I overlooked that the last part I questioned was just a cleanup. I'm ok with what you are going to do. Thanks for clarification! > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, August 28, 2019 6:54 AM > To: Kubacki, Michael A ; Chiu, Chasel > ;

Re: [edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-27 Thread Nate DeSimone
Hi Michael, Your responses address my comments from PATCH V2 as well. If Chasel has no further comments, go ahead and send a PATCH V4 and I will provide a reviewed-by. Thanks, Nate -Original Message- From: Kubacki, Michael A Sent: Monday, August 26, 2019 7:45 PM To: Chiu, Chasel ;

Re: [edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-26 Thread Kubacki, Michael A
My responses are inline [makubacki]. I will wait for your response before I send the next patchset. Thanks, Michael > -Original Message- > From: Chiu, Chasel > Sent: Monday, August 26, 2019 7:14 PM > To: Kubacki, Michael A ; > devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Gao,

Re: [edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-26 Thread Chiu, Chasel
Please see 3 questions below inline. (tagged by [chasel]) Thanks! Chasel > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, August 27, 2019 2:48 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-platforms][PATCH V3

[edk2-devel] [edk2-platforms][PATCH V3 2/2] WhiskeylakeOpenBoardPkg: Fix GCC Build Failures

2019-08-26 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2110 Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec