Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove batch build scripts
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Friday, August 9, 2019 9:35 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove > batch build scripts > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1775 > > Removed batch build scripts as they are replaced > > by build_bios.py > > Signed-off-by: Agyeman > --- > .../ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat | 79 --- > .../Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat| 159 - > .../Intel/ClevoOpenBoardPkg/N1xxWU/cln.bat| 48 > .../ClevoOpenBoardPkg/N1xxWU/postbuild.bat| 39 > .../ClevoOpenBoardPkg/N1xxWU/prebuild.bat | 214 -- > .../Intel/ClevoOpenBoardPkg/N1xxWU/prep.bat | 79 --- > 6 files changed, 618 deletions(-) > delete mode 100644 > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat > delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat > delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/cln.bat > delete mode 100644 > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/postbuild.bat > delete mode 100644 > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/prebuild.bat > delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/prep.bat > > diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat > b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat > deleted file mode 100644 > index 81f51b3785..00 > --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat > +++ /dev/null > @@ -1,79 +0,0 @@ > -@REM @file > -@REM > -@REM Copyright (c) 2019, Intel Corporation. All rights reserved. -@REM > SPDX-License-Identifier: BSD-2-Clause-Patent -@REM > - > -@echo off > - > -pushd ..\..\..\..\..\ > - > -@REM Set WORKSPACE environment. > -set WORKSPACE=%cd% > -echo. > -echo Set WORKSPACE as: %WORKSPACE% > -echo. > - > -@REM Check whether Git has been installed and been added to system path. > -git --help >nul 2>nul > -if %ERRORLEVEL% NEQ 0 ( > - echo. > - echo The 'git' command is not recognized. > - echo Please make sure that Git is installed and has been added to system > path. > - echo. > - goto :EOF > -) > - > -@REM Create the Conf directory under WORKSPACE -if not exist > %WORKSPACE%\Conf ( > - mkdir Conf > -) > - > -@REM Set other environments. > -@REM Basic Rule: > -@REM Platform override Silicon override Core > -@REM Source override Binary > - > -set PACKAGES_PATH=%WORKSPACE%\edk2- > platforms\Platform\Intel;%WORKSPACE%\edk2- > platforms\Silicon\Intel;%WORKSPACE%\edk2-non- > osi\Silicon\Intel;%WORKSPACE%\FSP;%WORKSPACE%\edk2;%WORKSPACE% > -set EDK_TOOLS_BIN=%WORKSPACE%\edk2-BaseTools-win32 > - > -@if not defined PYTHON_HOME ( > - @if exist C:\Python27 ( > -set PYTHON_HOME=C:\Python27 > - ) > -) > - > -set EDK_SETUP_OPTION= > -@rem if python is installed, disable the binary base tools. > -if defined PYTHON_HOME ( > - set EDK_TOOLS_BIN= > - set EDK_SETUP_OPTION=--nt32 > -) > -pushd %WORKSPACE%\edk2 > -call edksetup.bat %EDK_SETUP_OPTION% > -popd > -pushd %WORKSPACE% > -@rem if python is installed, nmake BaseTools source and enable BaseTools > source build -@if defined PYTHON_HOME ( > - nmake -f %BASE_TOOLS_PATH%\Makefile > -) > -popd > - > -set openssl_path=%WORKSPACE% > - > -popd > - > -goto :EOF > - > -:Help > -echo. > -echo Usage: > -echo GitEdk2.bat [-w Workspace_Directory] (optional) [-b Branch_Name] > (optional) -echo. > -echo -wA absolute/relative path to be the workspace. > -echo Default value is the current directory. > -echo. > -echo -bThe branch name of the repository. Currently, only master, > udk2015, > -echo trunk (same as master) and bp13 (same as udk2015) are supported. > -echo Default value is master. > -echo. > diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat > b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat > deleted file mode 100644 > index 606ce979a7..00 > --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat > +++ /dev/null > @@ -1,159 +0,0 @@ > -@REM @file > -@REM > -@REM Copyright (c) 2019, Intel Corporation. All rights reserved. -@REM > SPDX-License-Identifier: BSD-2-Clause-Patent -@REM > - > -:: Useage: bld [/s] [/f ] [/r] > -:: > -:: For a given build command, 3 options may be passed into this batch file > via > command prompt: > -:: 1) /s = Redirects all output to a file called EDK2.log(Prep.log must be > existed), > which will be located at the roo
Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove batch build scripts
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Friday, August 9, 2019 9:35 AM To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove batch build scripts Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1775 Removed batch build scripts as they are replaced by build_bios.py Signed-off-by: Agyeman --- .../ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat | 79 --- .../Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat| 159 - .../Intel/ClevoOpenBoardPkg/N1xxWU/cln.bat| 48 .../ClevoOpenBoardPkg/N1xxWU/postbuild.bat| 39 .../ClevoOpenBoardPkg/N1xxWU/prebuild.bat | 214 -- .../Intel/ClevoOpenBoardPkg/N1xxWU/prep.bat | 79 --- 6 files changed, 618 deletions(-) delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/cln.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/postbuild.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/prebuild.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/prep.bat diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat deleted file mode 100644 index 81f51b3785..00 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat +++ /dev/null @@ -1,79 +0,0 @@ -@REM @file -@REM -@REM Copyright (c) 2019, Intel Corporation. All rights reserved. -@REM SPDX-License-Identifier: BSD-2-Clause-Patent -@REM - -@echo off - -pushd ..\..\..\..\..\ - -@REM Set WORKSPACE environment. -set WORKSPACE=%cd% -echo. -echo Set WORKSPACE as: %WORKSPACE% -echo. - -@REM Check whether Git has been installed and been added to system path. -git --help >nul 2>nul -if %ERRORLEVEL% NEQ 0 ( - echo. - echo The 'git' command is not recognized. - echo Please make sure that Git is installed and has been added to system path. - echo. - goto :EOF -) - -@REM Create the Conf directory under WORKSPACE -if not exist %WORKSPACE%\Conf ( - mkdir Conf -) - -@REM Set other environments. -@REM Basic Rule: -@REM Platform override Silicon override Core -@REM Source override Binary - -set PACKAGES_PATH=%WORKSPACE%\edk2-platforms\Platform\Intel;%WORKSPACE%\edk2-platforms\Silicon\Intel;%WORKSPACE%\edk2-non-osi\Silicon\Intel;%WORKSPACE%\FSP;%WORKSPACE%\edk2;%WORKSPACE% -set EDK_TOOLS_BIN=%WORKSPACE%\edk2-BaseTools-win32 - -@if not defined PYTHON_HOME ( - @if exist C:\Python27 ( -set PYTHON_HOME=C:\Python27 - ) -) - -set EDK_SETUP_OPTION= -@rem if python is installed, disable the binary base tools. -if defined PYTHON_HOME ( - set EDK_TOOLS_BIN= - set EDK_SETUP_OPTION=--nt32 -) -pushd %WORKSPACE%\edk2 -call edksetup.bat %EDK_SETUP_OPTION% -popd -pushd %WORKSPACE% -@rem if python is installed, nmake BaseTools source and enable BaseTools source build -@if defined PYTHON_HOME ( - nmake -f %BASE_TOOLS_PATH%\Makefile -) -popd - -set openssl_path=%WORKSPACE% - -popd - -goto :EOF - -:Help -echo. -echo Usage: -echo GitEdk2.bat [-w Workspace_Directory] (optional) [-b Branch_Name] (optional) -echo. -echo -wA absolute/relative path to be the workspace. -echo Default value is the current directory. -echo. -echo -bThe branch name of the repository. Currently, only master, udk2015, -echo trunk (same as master) and bp13 (same as udk2015) are supported. -echo Default value is master. -echo. diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat deleted file mode 100644 index 606ce979a7..00 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat +++ /dev/null @@ -1,159 +0,0 @@ -@REM @file -@REM -@REM Copyright (c) 2019, Intel Corporation. All rights reserved. -@REM SPDX-License-Identifier: BSD-2-Clause-Patent -@REM - -:: Useage: bld [/s] [/f ] [/r] -:: -:: For a given build command, 3 options may be passed into this batch file via command prompt: -:: 1) /s = Redirects all output to a file called EDK2.log(Prep.log must be existed), which will be located at the root. -:: 2) /f = Defines the passing in of a single override to a feature PCD that is used in the platform -::DSC file. If this parameter is used, it is to be followed immediately after by both the feature -::pcd name and value. FeaturePcd is the full PCD name, like gMinPlatformPkgTokenSpaceGuid.PcdOptimizeCompilerEnable -:: 3) /r = Useful for faster rebuilds when no changes have been made to .inf files. Passes -u to -::build.exe to skip the generation of makefiles. -:: 4) rom = Build Bios.rom only and building SPIs will be skipped. -:: - -@echo on - -cd %WORKSPACE% - -@REM -@REM Build FSP Binary -@REM -@if not defined FSP_BINARY_BUILD goto :SkipFspBinaryBuild -@if %FSP_BINARY_BUILD% EQU FALSE goto :SkipFspBinaryBuild
[edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove batch build scripts
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1775 Removed batch build scripts as they are replaced by build_bios.py Signed-off-by: Agyeman --- .../ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat | 79 --- .../Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat| 159 - .../Intel/ClevoOpenBoardPkg/N1xxWU/cln.bat| 48 .../ClevoOpenBoardPkg/N1xxWU/postbuild.bat| 39 .../ClevoOpenBoardPkg/N1xxWU/prebuild.bat | 214 -- .../Intel/ClevoOpenBoardPkg/N1xxWU/prep.bat | 79 --- 6 files changed, 618 deletions(-) delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/cln.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/postbuild.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/prebuild.bat delete mode 100644 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/prep.bat diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat deleted file mode 100644 index 81f51b3785..00 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/GitEdk2Clevo.bat +++ /dev/null @@ -1,79 +0,0 @@ -@REM @file -@REM -@REM Copyright (c) 2019, Intel Corporation. All rights reserved. -@REM SPDX-License-Identifier: BSD-2-Clause-Patent -@REM - -@echo off - -pushd ..\..\..\..\..\ - -@REM Set WORKSPACE environment. -set WORKSPACE=%cd% -echo. -echo Set WORKSPACE as: %WORKSPACE% -echo. - -@REM Check whether Git has been installed and been added to system path. -git --help >nul 2>nul -if %ERRORLEVEL% NEQ 0 ( - echo. - echo The 'git' command is not recognized. - echo Please make sure that Git is installed and has been added to system path. - echo. - goto :EOF -) - -@REM Create the Conf directory under WORKSPACE -if not exist %WORKSPACE%\Conf ( - mkdir Conf -) - -@REM Set other environments. -@REM Basic Rule: -@REM Platform override Silicon override Core -@REM Source override Binary - -set PACKAGES_PATH=%WORKSPACE%\edk2-platforms\Platform\Intel;%WORKSPACE%\edk2-platforms\Silicon\Intel;%WORKSPACE%\edk2-non-osi\Silicon\Intel;%WORKSPACE%\FSP;%WORKSPACE%\edk2;%WORKSPACE% -set EDK_TOOLS_BIN=%WORKSPACE%\edk2-BaseTools-win32 - -@if not defined PYTHON_HOME ( - @if exist C:\Python27 ( -set PYTHON_HOME=C:\Python27 - ) -) - -set EDK_SETUP_OPTION= -@rem if python is installed, disable the binary base tools. -if defined PYTHON_HOME ( - set EDK_TOOLS_BIN= - set EDK_SETUP_OPTION=--nt32 -) -pushd %WORKSPACE%\edk2 -call edksetup.bat %EDK_SETUP_OPTION% -popd -pushd %WORKSPACE% -@rem if python is installed, nmake BaseTools source and enable BaseTools source build -@if defined PYTHON_HOME ( - nmake -f %BASE_TOOLS_PATH%\Makefile -) -popd - -set openssl_path=%WORKSPACE% - -popd - -goto :EOF - -:Help -echo. -echo Usage: -echo GitEdk2.bat [-w Workspace_Directory] (optional) [-b Branch_Name] (optional) -echo. -echo -wA absolute/relative path to be the workspace. -echo Default value is the current directory. -echo. -echo -bThe branch name of the repository. Currently, only master, udk2015, -echo trunk (same as master) and bp13 (same as udk2015) are supported. -echo Default value is master. -echo. diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat deleted file mode 100644 index 606ce979a7..00 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/bld.bat +++ /dev/null @@ -1,159 +0,0 @@ -@REM @file -@REM -@REM Copyright (c) 2019, Intel Corporation. All rights reserved. -@REM SPDX-License-Identifier: BSD-2-Clause-Patent -@REM - -:: Useage: bld [/s] [/f ] [/r] -:: -:: For a given build command, 3 options may be passed into this batch file via command prompt: -:: 1) /s = Redirects all output to a file called EDK2.log(Prep.log must be existed), which will be located at the root. -:: 2) /f = Defines the passing in of a single override to a feature PCD that is used in the platform -::DSC file. If this parameter is used, it is to be followed immediately after by both the feature -::pcd name and value. FeaturePcd is the full PCD name, like gMinPlatformPkgTokenSpaceGuid.PcdOptimizeCompilerEnable -:: 3) /r = Useful for faster rebuilds when no changes have been made to .inf files. Passes -u to -::build.exe to skip the generation of makefiles. -:: 4) rom = Build Bios.rom only and building SPIs will be skipped. -:: - -@echo on - -cd %WORKSPACE% - -@REM -@REM Build FSP Binary -@REM -@if not defined FSP_BINARY_BUILD goto :SkipFspBinaryBuild -@if %FSP_BINARY_BUILD% EQU FALSE goto :SkipFspBinaryBuild -@set FSP_BUILD_PARAMETER=/d -@set FSP_PKG_NAME=KabylakeFspPkg -@if /I "%TARGET%" == "RELEASE" ( - @if "%FSP_TEST_RELEASE%"=="TRUE" ( -set FSP_BUILD_PARAMETER=/tr - ) else ( -set FSP_BUILD_PARAMETER=/r - ) -) - -@if %FSP_WRAPPER_BUILD% EQU FALSE goto :BldEnd
