Nathaniel L
>
> Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 2/5]
> KabylakeOpenBoardPkg/KabylakeRvp3: Add BIOS Info PEIM
>
> BiosInfo.c:
>
> BiosInfoEntryPoint () function description should be updated. The function
> installs the BiosInfo PPI but also produces the
BiosInfo.c:
BiosInfoEntryPoint () function description should be updated. The function
installs the BiosInfo PPI
but also produces the BiosInfo HOB.
It also looks like you can remove the following macros:
#define INDEXPORT_TO_ADDRESS(x) (x)
#define DATAPORT_TO_ADDRESS(x)
For now, this is definitely possible.
It may also be viable long term. The table is closely tied to the FV layout
which is
standardized under Minimum Platform. Firmware volumes that may come and go like
those for
a particular advanced feature would end up as child FVs under a FvAdvanced
parent
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c and
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c are
identical files. Can we move this up to the parent KabylakeOpenBoardPkg and use
one PEIM for both platforms?
-Original Message-
From: Agyeman,
Added BIOS Info PEIM to KabylakeRvp3 to publish
the BIOS info HOB. This PEIM currently publishs
the board's microcode region info.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../KabylakeRvp3/BiosInfo/BiosInfo.c | 93 +++
