Same feedback as patch #2:
BiosInfo.c:
BiosInfoEntryPoint () function description should be updated. The function
installs the BiosInfo PPI
but also produces the BiosInfo HOB.
It also looks like you can remove the following macros for now:
#define INDEXPORT_TO_ADDRESS(x) (x)
Same comment as PATCH 2 & 3, it seems like this PEIM could be used generically
by any Whiskeylake board so I would prefer one copy of it in
WhiskeylakeOpenBoardPkg.
-Original Message-
From: Agyeman, Prince
Sent: Thursday, October 3, 2019 2:13 PM
To: devel@edk2.groups.io
Cc: Sinha,
Added BIOS info PEIM to publish Bios Info
HOB. This PEIM currently publishes the microcode
FV info.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../WhiskeylakeURvp/BiosInfo/BiosInfo.c | 93 +++