Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-13 Thread Nate DeSimone
Thanks for the feedback Chasel and Sai! I have incorporated all your suggestions. > -Original Message- > From: Chaganty, Rangasai V > Sent: Thursday, May 9, 2024 6:15 PM > To: Desimone, Nathaniel L ; > devel@edk2.groups.io > Cc: Chiu, Chasel ; Liming Gao > ; Dong, Eric ; Chuang, > Rosen

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-09 Thread Chaganty, Rangasai V
Hi Nate, Looks good. In addition to optimization suggested by Chasel to save unnecessary call to locate PPI, you might also want to consider checking for checking "no error" status for locate PPI and perhaps avoid a "goto" label. With that, Reviewed-by: Sai Chaganty for the whole patch

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-09 Thread Chiu, Chasel
Hi Nate, Change looks good. Reviewed-by: Chasel Chiu Just one minor optimization you might consider in below inline when merging this patch series. Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, May 8, 2024 5:09 PM > To: devel@edk2.groups.io

[edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-08 Thread Nate DeSimone
MpInfo2HobPei provides backwards compatibility between FSP binaries built with older versions of EDK II and the latest EDK II. Newer versions of CpuMpPei produce the gMpInformation2HobGuid. This HOB is required by newer implementations of the CPU DXE driver, however older versions of CpuMpPei do