> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Friday, March 17, 2023 7:20 AM
> To: devel@edk2.groups.io; mhaeu...@posteo.de; Gerd Hoffmann
>
> Cc: Kinney, Michael D
> Subject: Re: [edk2-devel] [edk2-platforms] Enable GitHub PR, protected
nney, Michael D ; Marvin Häuser
>
> Subject: Re: [edk2-devel] [edk2-platforms] Enable GitHub PR, protected
> branches, and 'push' label
>
> Sorry, it might be the sourceforge mailing list that got lost, not
> lists.01.org. I was wanting to see the review of the following commit,
&g
On 3/17/23 7:44 AM, Gerd Hoffmann wrote:
Agree. Also from the web-based review tools I've worked with so far
(not much, only github and gitlab) github is the better one.
Having used Review Board, Gitlab, Github, Phabricator, Gerrit and
probably others, Gerrit is by far my least favorite.
I
On 3/17/23 8:08 AM, Marvin Häuser wrote:
On 17. Mar 2023, at 14:44, Gerd Hoffmann wrote:
Yes, this. For active PRs this usually isn't much of a problem. But
try come back after a few months, or even a few years (see Rebecca
trying to lookup context for a 2016 commit in the archives).
I also
> On 17. Mar 2023, at 14:44, Gerd Hoffmann wrote:
>
> On Fri, Mar 17, 2023 at 12:32:15PM +, Marvin Häuser wrote:
>> Hi Rebecca and Gerd,
>>
>> Replying to 2 mails at once...
>>
On 17. Mar 2023, at 11:36, Rebecca Cran wrote:
>>>
>>> I like that proposed workflow.
>>>
>>> I've
On Fri, Mar 17, 2023 at 12:32:15PM +, Marvin Häuser wrote:
> Hi Rebecca and Gerd,
>
> Replying to 2 mails at once...
>
> > On 17. Mar 2023, at 11:36, Rebecca Cran wrote:
> >
> > I like that proposed workflow.
> >
> > I've also been wondering if we could consider choosing a different
> >
On 3/17/23 6:32 AM, Marvin Häuser wrote:
On 17. Mar 2023, at 11:36, Rebecca Cran wrote:
I like that proposed workflow.
I've also been wondering if we could consider choosing a different
product for patch reviews that supports our desired workflow better,
such as Gitlab or Phorge (the new
Hi Rebecca and Gerd,
Replying to 2 mails at once...
> On 17. Mar 2023, at 11:36, Rebecca Cran wrote:
>
> I like that proposed workflow.
>
> I've also been wondering if we could consider choosing a different product
> for patch reviews that supports our desired workflow better, such as
Sorry, it might be the sourceforge mailing list that got lost, not
lists.01.org. I was wanting to see the review of the following commit,
but Google isn't finding anything:
commit a61331e8b78ba264f0ccd011b6dc5b9e809730a5
Author: Liming Gao
Date: Mon Aug 22 14:32:23 2016 +0800
Talking about mailing lists, I'm still disappointed that we lost so much
history of discussion and reviews around the project when the edk2-devel
archive at lists.01.org was deleted.
I've sometimes wanted to go back and take a look at the review history
of a certain commit only to find it's
I like that proposed workflow.
I've also been wondering if we could consider choosing a different
product for patch reviews that supports our desired workflow better,
such as Gitlab or Phorge (the new Phabricator project).
If anyone would be willing to donate money for colocation, I'd be
On Thu, Mar 16, 2023 at 01:59:49PM -0600, Rebecca Cran wrote:
> Is this still a requirement since Laszlo's departure from the project?
>
> I seem to recall it was him who made it a sticking point of moving to a
> GitHub PR workflow originally with the requirement to have emails of
> everything.
@edk2.groups.io
*Subject:* Re: [edk2-devel] [edk2-platforms] Enable GitHub PR,
protected branches, and 'push' label
Hi Mike,
Could this be extended to allow for a full PR workflow, if the package
maintainers would prefer so? We would like to utilise this for
Ext4Pkg. It could be considered
Well, in this form, it complicates our workflow and adds no value. NACK from
Pedro and me till there at least is CI.
Best regards,
Marvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101283):
.groups.io
Subject: Re: [edk2-devel] [edk2-platforms] Enable GitHub PR, protected
branches, and 'push' label
Hi Mike,
Could this be extended to allow for a full PR workflow, if the package
maintainers would prefer so? We would like to utilise this for Ext4Pkg. It
could be considered a trial
Hi Mike,
Could this be extended to allow for a full PR workflow, if the package
maintainers would prefer so? We would like to utilise this for Ext4Pkg. It
could be considered a trial. :)
Best regards,
Marvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
This is a proposal to enable the GitHub PR feature on the edk2-platforms
repository and enable branch protections that would require maintainers
to set a 'push' label to merge change into edk2-platforms. The same
process that is already in place on the edk2 repository.
The initial change would
17 matches
Mail list logo
