Re: [edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
As noted by others, please update copyright year. With that change... Reviewed-by: Nate DeSimone -Original Message- From: Zhang, Shenglei Sent: Thursday, August 22, 2019 12:08 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Zhang, Shenglei Subject: [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file to make sure that the deprecated APIs will not be used in our code. https://bugzilla.tianocore.org/show_bug.cgi?id=2111 Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Shenglei Zhang --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc index 8a3638b7..9bbb7963 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -187,3 +187,6 @@ MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf !endif + +[BuildOptions] + *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No newline at end of file -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46341): https://edk2.groups.io/g/devel/message/46341 Mute This Topic: https://groups.io/mt/32987576/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
Please extend the file copyright date. With that change: Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, August 22, 2019 12:08 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Zhang, Shenglei > Subject: [edk2-devel] [edk2-platforms PATCH 3/4] > Platform/MinPlatformPkg.dsc: Add build option > > Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file > to make sure that the deprecated APIs will not be used in our code. > https://bugzilla.tianocore.org/show_bug.cgi?id=2111 > > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 8a3638b7..9bbb7963 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -187,3 +187,6 @@ >MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf >MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf > !endif > + > +[BuildOptions] > + *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > \ No newline at end of file > -- > 2.18.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46318): https://edk2.groups.io/g/devel/message/46318 Mute This Topic: https://groups.io/mt/32987576/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
This file still having 2018 in copyright, so please help to extend it. With above change Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, August 22, 2019 3:08 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Zhang, Shenglei > Subject: [edk2-devel] [edk2-platforms PATCH 3/4] > Platform/MinPlatformPkg.dsc: Add build option > > Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file > to make sure that the deprecated APIs will not be used in our code. > https://bugzilla.tianocore.org/show_bug.cgi?id=2111 > > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > index 8a3638b7..9bbb7963 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > @@ -187,3 +187,6 @@ >MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf >MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf > !endif > + > +[BuildOptions] > + *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > \ No newline at end of file > -- > 2.18.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46223): https://edk2.groups.io/g/devel/message/46223 Mute This Topic: https://groups.io/mt/32987576/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file to make sure that the deprecated APIs will not be used in our code. https://bugzilla.tianocore.org/show_bug.cgi?id=2111 Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Shenglei Zhang --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc index 8a3638b7..9bbb7963 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -187,3 +187,6 @@ MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf !endif + +[BuildOptions] + *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No newline at end of file -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46201): https://edk2.groups.io/g/devel/message/46201 Mute This Topic: https://groups.io/mt/32987576/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
