Sent: Thursday, August 25, 2022 4:13 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; af...@apple.com
<mailto:af...@apple.com>
Cc: Kinney, Michael D mailto:michael.d.kin...@intel.com> >
Subject: Re: [edk2-devel] BaseTools no longer builds on macOS: "error: un
ppropriate for that issue as well.
Mike
*From:*Rebecca Cran
*Sent:* Thursday, August 25, 2022 4:13 PM
*To:* devel@edk2.groups.io; af...@apple.com
*Cc:* Kinney, Michael D
*Subject:* Re: [edk2-devel] BaseTools no longer builds on macOS:
"error: unknown warning option '-Werror=stringop-over
no longer builds on macOS: "error: unknown
warning option '-Werror=stringop-overflow'"
Thanks, that patch works. Is it too late to get it in for the stable tag?
Reviewed-by: Rebecca Cran <mailto:rebe...@bsdio.com>
On 8/25/22 11:49, Andrew Fish via groups.io wrote:
Maybe havin
Thanks, that patch works. Is it too late to get it in for the stable tag?
Reviewed-by: Rebecca Cran
On 8/25/22 11:49, Andrew Fish via groups.io wrote:
Maybe having the check last would be cleaner.
*diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile
Maybe having the check last would be cleaner.
diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile
b/BaseTools/Source/C/DevicePath/GNUmakefile
index c217674345b1..17f213879e82 100644
--- a/BaseTools/Source/C/DevicePath/GNUmakefile
+++ b/BaseTools/Source/C/DevicePath/GNUmakefile
@@ -16,10
Rebecca,
FYI /usr/bin/gcc has been a redirector into clang for a lot of years.
The build picks different default sets of complier flags based on build type.
There is already code that assumes gcc == clang here [1]
I think the issue is the check that is wrapping "BUILD_CFLAGS +=
BaseTools no longer builds on macOS (12.5.1, Monterey), because 'gcc' in
/usr/bin is really clang.
I tried installing gcc 12 from Homebrew, but the build then failed
saying it couldn't find _stdio.h.
It appears the breakage might have been introduced in this commit back
in March:
commit
