RE: [PATCH] ota_tokenize_bookmarks

2006-04-07 Thread Rene Kluwen
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Alexander Malysh Sent: donderdag 6 april 2006 12:01 To: devel@kannel.org Subject: Re: ota_tokenize_bookmarks Hi Rene, you are right about memleaks. Could you please provide patch? Thanks, Alex Rene Kluwen

Re: [PATCH] ota_tokenize_bookmarks

2006-04-07 Thread Alexander Malysh
Hi, committed to cvs. Thanks, Alex Rene Kluwen schrieb: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Alexander Malysh Sent: donderdag 6 april 2006 12:01 To: devel@kannel.org Subject: Re: ota_tokenize_bookmarks Hi Rene, you are right about

Re: [PATCH] more precise throughput using double [v3]

2006-04-07 Thread Alexander Malysh
Hi, this patch applies ok and committed to cvs in modified form. +throughput = strtod(octstr_get_cstr(cfg_get(grp, octstr_imm(throughput))),(char **) NULL); +if (throughput == ERANGE || throughput = 0) conn-throughput = 0; /* defaults to no throughtput ... Here you have

Re: [PATCH] more precise throughput using double [v3]

2006-04-07 Thread Vincent CHAVANIS
Thanks++, I did not see that point. Vincent -- Telemaque - NICE - (FR) Service Technique - Developpement http://www.telemaque.fr/ [EMAIL PROTECTED] Tel : +33 4 93 97 71 64 (fax 68) - Original Message - From: Alexander Malysh [EMAIL PROTECTED] To: devel@kannel.org Sent: Friday, April

Re: [PATCH] Logs in milisec

2006-04-07 Thread Vincent CHAVANIS
Hi, What about this patch to CVS ? No comments on it ? regards -- Telemaque - NICE - (FR) Service Technique - Developpement http://www.telemaque.fr/ [EMAIL PROTECTED] Tel : +33 4 93 97 71 64 (fax 68) - Original Message - From: Vincent CHAVANIS [EMAIL PROTECTED] To: devel@kannel.org

Re: [PATCH] Logs in milisec

2006-04-07 Thread Alexander Malysh
Hi, I don't really see a point in committing it. But if others find it useful will not block it. so +0 from me. comments/votes please! Thanks, Alex Vincent CHAVANIS schrieb: Hi, What about this patch to CVS ? No comments on it ? regards -- Telemaque - NICE - (FR) Service Technique -

Re: [PATCH] more precise throughput using double [v3]

2006-04-07 Thread Alexander Malysh
Vincent CHAVANIS schrieb: Thanks++, I did not see that point. cfg_get(...) returns Octstr* that must be destroyed afterwards. and we avoid using strXXX functions if we have the same functionality in Octstr. Thanks, Alex Vincent -- Telemaque - NICE - (FR) Service Technique -

Re: [PATCH] more precise throughput using double [v3]

2006-04-07 Thread Vincent CHAVANIS
wow, something is going wrong with your modifications. Here is the fix, --- /gateway-cvs/gw/smscconn.c 2006-04-07 14:54:05.0 +0200 +++ /gateway/gw/smscconn.c 2006-04-07 16:54:44.0 +0200 @@ -220,8 +220,10 @@ if ((tmp = cfg_get(grp, octstr_imm(throughput))) != NULL) {