Re: PATCH: Memory leak in Clickatell + Brunet HTTP SMSC

2008-07-14 Thread Stipe Tolj
Donald Jackson schrieb: Hi everyone, Attached is a diff for memory leak found in smsc_http.c for Clickatell and Brunet specific implementations. The message ID Octstr's never get destroyed when the dictionary gets destroyed. and after Werner's correction to my mail, +1, and committed to CVS:

Re: PATCH: Memory leak in Clickatell + Brunet HTTP SMSC

2008-07-14 Thread Stipe Tolj
Werner Coetzee schrieb: Hi Stipe I must disagree with you (unfortunately). If you look closely, you'll see that: word = gwlist_extract_first(words); and value = gwlist_extract_first(words); is used on the list, (i.e. 2 elements removed from the list), and when gwlist_destroy is called, 'word' a

RE: PATCH: Memory leak in Clickatell + Brunet HTTP SMSC

2008-07-14 Thread Werner Coetzee
ee * C Developer: Messaging Engine * T +27 21 910 7700 * F +27 21 910 7701 [EMAIL PROTECTED] www.clickatell.com -Original Message- From: Stipe Tolj [mailto:[EMAIL PROTECTED] Sent: 14 July 2008 17:13 Cc: devel@kannel.org Subject: Re: PATCH: Memory leak in Clickatell + Brun

Re: PATCH: Memory leak in Clickatell + Brunet HTTP SMSC

2008-07-14 Thread Stipe Tolj
Donald Jackson schrieb: Hi everyone, Attached is a diff for memory leak found in smsc_http.c for Clickatell and Brunet specific implementations. The message ID Octstr's never get destroyed when the dictionary gets destroyed. -1 on this patch. Reason: we do a double free() on the Octstr point

PATCH: Memory leak in Clickatell + Brunet HTTP SMSC

2008-07-14 Thread Donald Jackson
Hi everyone, Attached is a diff for memory leak found in smsc_http.c for Clickatell and Brunet specific implementations. The message ID Octstr's never get destroyed when the dictionary gets destroyed. Thank you! -- Donald Jackson http://www.ddj.co.za/ donaldjster(a)gmail.com smsc_http.c.diff D