Re: Submitting a patch to Kannel: best practices?

2010-12-21 Thread Alexander Malysh
To: Nikos Balkanas Cc: David McCann ; devel@kannel.org Sent: Friday, December 17, 2010 5:04 PM Subject: Re: Submitting a patch to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between

Re: Submitting a patch to Kannel: best practices?

2010-12-21 Thread Milan P. Stanic
to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between bearerbox and smsbox (see restart command as example). Then you don't need extra admin interface for smsbox

Re: Submitting a patch to Kannel: best practices?

2010-12-19 Thread Nikos Balkanas
than smppbox or smsbox and bb cannot tell them apart. BR, Nikos - Original Message - From: Alexander Malysh To: Nikos Balkanas Cc: David McCann ; devel@kannel.org Sent: Friday, December 17, 2010 5:04 PM Subject: Re: Submitting a patch to Kannel: best practices? Hi

Re: Submitting a patch to Kannel: best practices?

2010-12-19 Thread Alejandro Guerrieri
to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between bearerbox and smsbox (see restart command as example). Then you don't need extra admin interface for smsbox. Thanks

Re: Submitting a patch to Kannel: best practices?

2010-12-19 Thread David McCann
requirements than smppbox or smsbox and bb cannot tell them apart. BR, Nikos - Original Message - From: Alexander Malysh To: Nikos Balkanas Cc: David McCann ; devel@kannel.orgdevel@kannel.org Sent: Friday, December 17, 2010 5:04 PM Subject: Re: Submitting a patch to Kannel

Re: Submitting a patch to Kannel: best practices?

2010-12-18 Thread Nikos Balkanas
To: Nikos Balkanas Cc: David McCann ; devel@kannel.org Sent: Friday, December 17, 2010 5:04 PM Subject: Re: Submitting a patch to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between

Re: Submitting a patch to Kannel: best practices?

2010-12-18 Thread Nikos Balkanas
than smppbox or smsbox and bb cannot tell them apart. BR, Nikos - Original Message - From: Alexander Malysh To: Nikos Balkanas Cc: David McCann ; devel@kannel.org Sent: Friday, December 17, 2010 5:04 PM Subject: Re: Submitting a patch to Kannel: best practices? Hi

Re: Submitting a patch to Kannel: best practices?

2010-12-18 Thread Alejandro Guerrieri
: Friday, December 17, 2010 5:04 PM Subject: Re: Submitting a patch to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between bearerbox and smsbox (see restart command as example

Re: Submitting a patch to Kannel: best practices?

2010-12-18 Thread Alejandro Guerrieri
To: Nikos Balkanas Cc: David McCann ; devel@kannel.org Sent: Friday, December 17, 2010 5:04 PM Subject: Re: Submitting a patch to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication

Re: Submitting a patch to Kannel: best practices?

2010-12-18 Thread David McCann
: Submitting a patch to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between bearerbox and smsbox (see restart command as example). Then you don't need extra admin interface for smsbox

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread Nikos Balkanas
Hi, Usually people just post the patch to the devel list with subject: Patch: filename. Patch is attached as a diff of the file(s) from latest svn sources, followed by a brief description in the body. Wrt to your proposed solution, I am not very much in favor. In bearerbox this is handle on the

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread Alexander Malysh
Hi David, the best way to submit patches, is to post it to mailing list, in unified diff format. Thanks, Alexander Malysh Am 17.12.2010 um 07:10 schrieb David McCann: Greetings all! I've been a kannel user for years, but within the past week I've just started to work directly with the

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread David McCann
Hi Nikos-- Thank you for the promt reply! I completely agree that this makes more sense as a bearerbox, admin command. I initially added it as such, but then realized that in fact, all the translations logic sat within the smsbox process, rather than the bearerbox. Adding it directly as an

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread Nikos Balkanas
Hi David, Yes. bb has its own black/white lists for incoming MO traffic, similar to smsbox's MT. These can be reloaded on the fly through its http admin interface. Another very useful feature is that it allows you to change log-levels on the fly. Very useful for debugging. Check gw/bb_http.c:

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread Alexander Malysh
Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between bearerbox and smsbox (see restart command as example). Then you don't need extra admin interface for smsbox. Thanks, Alexander Malysh Am 17.12.2010 um 14:49 schrieb

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread David McCann
Hi Nikos-- Yikes, I think I'm even more confused. I should probably again explain that I've been a kannel *user* for years, and have found it a wonderful tool for managing SMPP links out-of-the-box, with no stress whatsoever. I should explain my current understanding of Kannel's (1.4.3)

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread David McCann
Nikos/Alexander-- Thanks for the feedback! I'll take a look at restart to find the code proper pattern...is everyone in agreement that this is the way it should work? If so, I'll take some more time and submit a new patch. Cheers (and happy holidays), --dm On Fri, Dec 17, 2010 at 6:04 PM,

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread Nikos Balkanas
a patch to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between bearerbox and smsbox (see restart command as example). Then you don't need extra admin interface for smsbox. Thanks, Alexander Malysh

Re: Submitting a patch to Kannel: best practices?

2010-12-17 Thread Alejandro Guerrieri
17, 2010 5:04 PM Subject: Re: Submitting a patch to Kannel: best practices? Hi, it would be better to let bearerbox tell smsbox to reload lists. admin message already exists for communication between bearerbox and smsbox (see restart command as example). Then you don't need extra

Submitting a patch to Kannel: best practices?

2010-12-16 Thread David McCann
Greetings all! I've been a kannel user for years, but within the past week I've just started to work directly with the code. I had a particular need which I couldn't find a good workaround for: My current deployment with kannel uses whitelisting to dispatch messages to various running web