Re: [PATCH] KSMPPD (and other?) utility methods for smpp_pdu.c

Am 26.09.2016 19:47, schrieb Donald Jackson: Fair point, ignore this patch in that case :) np, we're happy that you're active... we still need to get SOMETHING, before refusing it ;) Stipe -- Best Regards, Stipe Tolj ---

Re: [PATCH] KSMPPD (and other?) utility methods for smpp_pdu.c

Fair point, ignore this patch in that case :) On 26 September 2016 at 19:43, Stipe Tolj wrote: > Am 26.09.2016 19:38, schrieb Donald Jackson: > >> As I say this is semantics, its not entirely necessary. >> >> Usually in library functions they are compatible with each other,

Re: [PATCH] KSMPPD (and other?) utility methods for smpp_pdu.c

Am 26.09.2016 19:38, schrieb Donald Jackson: As I say this is semantics, its not entirely necessary. Usually in library functions they are compatible with each other, eg: SMPP_PDU *pdu = smpp_pdu_unpack(smpp_pdu_pack(data)); Would work, but in Kannel's case this doesn't work as the one

Re: [PATCH] KSMPPD (and other?) utility methods for smpp_pdu.c

As I say this is semantics, its not entirely necessary. Usually in library functions they are compatible with each other, eg: SMPP_PDU *pdu = smpp_pdu_unpack(smpp_pdu_pack(data)); Would work, but in Kannel's case this doesn't work as the one function uses length and the other does not. So the

Re: [PATCH] Reduce logging in dbpool_mysql.c

Am 24.09.2016 13:57, schrieb Rene Kluwen: I don’t agree completely with your reasoning. Either you want debug information or you don’t. Enabling debug information yields a lot of information. What about if you want to debug the mysql pool usage? Still +0 from me in case it’s redundant info.

Re: [PATCH] KSMPPD (and other?) utility methods for smpp_pdu.c

Am 24.09.2016 13:58, schrieb Rene Kluwen: Sure, but why not change KSMPPD to use smpp_pdu_pack() function without the length? correct, IF this is something ksmppd needs/wants, then it needs to handle it on it's side. What is the purpose of NOT having the length being added? Stipe -- Best

Re: [PATCH] Memory leak in smpp_pdu.c

Am 24.09.2016 13:55, schrieb Rene Kluwen: +1 from me. yep, good catch Donald. +1 for it. If no objections, will commit. -- Best Regards, Stipe Tolj --- Düsseldorf, NRW, Germany Kannel Foundation tolj.org