Thank you for your review and help,
I have made the modifications and post v3 patch.
Thanks,
Yulong
--
Crash-utility mailing list -- devel@lists.crash-utility.osci.io
To unsubscribe send an email to devel-le...@lists.crash-utility.osci.io
On 2024/03/11 18:08, Tang Yulong wrote:
> Hi, Kazu:
>
>> On 2024/03/01 17:48, Tao Liu wrote:
>>
>> hmm, as far as I know, not many kernels are configured with
>> CONFIG_IKCONFIG=y, e.g. RHEL kernels don't have it. so if it depends
>> only on ikconfig, it will not work on many kernels.
>>
>
>
Hi, Kazu:
> On 2024/03/01 17:48, Tao Liu wrote:
>
> hmm, as far as I know, not many kernels are configured with
> CONFIG_IKCONFIG=y, e.g. RHEL kernels don't have it. so if it depends
> only on ikconfig, it will not work on many kernels.
>
Thank you for the correction.
> It's good to use
On 2024/03/01 17:48, Tao Liu wrote:
> Hi Yulong,
>
> On Fri, Mar 1, 2024 at 4:25 PM tang yulong <1637403...@qq.com> wrote:
>>
>>> Hi Yulong,
>>>
>>> Thanks for your patch!
>>>
>>> On Mon, Feb 26, 2024 at 3:20 PM Yulong TANG 汤玉龙 >> wrote:
>>>
>>> I have no objection to the lzo-rle decompression
On 2024/03/01 12:24, Yulong TANG 汤玉龙 wrote:
> Hi Kazu,
>
> I have tried to decompress lzo-rle using the same approach as lzo, with
> only the following modifications:
>
> if (STREQ(name, "lzo")) ---> if (STREQ(name, "lzo") ||
> STREQ(name, "lzo-rle"))
>
>
> but the result is not
Thank you for your detailed comments.
Thanks,
Yulong
--
Crash-utility mailing list -- devel@lists.crash-utility.osci.io
To unsubscribe send an email to devel-le...@lists.crash-utility.osci.io
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines:
Hi Yulong,
On Fri, Mar 1, 2024 at 5:46 PM Tang Yulong <1637403...@qq.com> wrote:
>
> OK, I have made the modifications as per your suggestions. Should I proceed
> with resubmitting the patch? And how should I acknowledge your contribution?
> I'm not quite clear on that for the first submission.
OK, I have made the modifications as per your suggestions. Should I proceed
with resubmitting the patch? And how should I acknowledge your contribution?
I'm not quite clear on that for the first submission. Thank you for your
guidance.
Thanks,
Yulong
diff --git a/lzorle_decompress.c
Hi Yulong,
On Fri, Mar 1, 2024 at 4:25 PM tang yulong <1637403...@qq.com> wrote:
>
> > Hi Yulong,
> >
> > Thanks for your patch!
> >
> > On Mon, Feb 26, 2024 at 3:20 PM Yulong TANG 汤玉龙 > wrote:
> >
> > I have no objection to the lzo-rle decompression feature for crash.
> > However I have some
> Hi Yulong,
>
> Thanks for your patch!
>
> On Mon, Feb 26, 2024 at 3:20 PM Yulong TANG 汤玉龙 wrote:
>
> I have no objection to the lzo-rle decompression feature for crash.
> However I have some concern of your patch:
>
> The patch you attached is a "lzorle_decompress_safe" implementation
>
Hi Kazu and Yulong,
On Fri, Mar 1, 2024 at 9:33 AM HAGIO KAZUHITO(萩尾 一仁) wrote:
>
> On 2024/03/01 9:29, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > On 2024/02/29 19:08, Tao Liu wrote:
> >> Hi Yulong,
> >>
> >> Thanks for your patch!
> >>
> >> On Mon, Feb 26, 2024 at 3:20 PM Yulong TANG 汤玉龙
> >> wrote:
>
Hi Kazu,
I have tried to decompress lzo-rle using the same approach as lzo, with only
the following modifications:
if (STREQ(name, "lzo")) ---> if (STREQ(name, "lzo") || STREQ(name,
"lzo-rle"))
but the result is not successful.
crash> gcore -v 0 1
gcore: WARNING: zram
Hi Tao,
Thanks for your review and the suggestion of an alternative approach.
I will try this method, but as Kazu mentioned, my environment consists of an
X86 crash and an ARM64 vmcore, so I believe it might be challenging to succeed.
Thanks,
Yulong
--
Crash-utility mailing list --
On 2024/03/01 9:29, HAGIO KAZUHITO(萩尾 一仁) wrote:
> On 2024/02/29 19:08, Tao Liu wrote:
>> Hi Yulong,
>>
>> Thanks for your patch!
>>
>> On Mon, Feb 26, 2024 at 3:20 PM Yulong TANG 汤玉龙 wrote:
>>>
>>> In Linux 5.1, the ZRAM block driver has changed its default compressor from
>>> "lzo" to
On 2024/02/29 19:08, Tao Liu wrote:
> Hi Yulong,
>
> Thanks for your patch!
>
> On Mon, Feb 26, 2024 at 3:20 PM Yulong TANG 汤玉龙 wrote:
>>
>> In Linux 5.1, the ZRAM block driver has changed its default compressor from
>> "lzo" to "lzo-rle" to enhance LZO compression support. However, crash does
On Thu, Feb 29, 2024 at 6:08 PM Tao Liu wrote:
>
> Hi Yulong,
>
> Thanks for your patch!
>
> On Mon, Feb 26, 2024 at 3:20 PM Yulong TANG 汤玉龙 wrote:
> >
> > In Linux 5.1, the ZRAM block driver has changed its default compressor from
> > "lzo" to "lzo-rle" to enhance LZO compression support.
Hi Yulong,
Thanks for your patch!
On Mon, Feb 26, 2024 at 3:20 PM Yulong TANG 汤玉龙 wrote:
>
> In Linux 5.1, the ZRAM block driver has changed its default compressor from
> "lzo" to "lzo-rle" to enhance LZO compression support. However, crash does
> not support the improved LZO algorithm,
17 matches
Mail list logo
