Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-06 Thread Michal Schorm
I further discussed it with Neil. We came to a compromise. We will document this macro and its potential usage, as well as the warning why and when it shouldn't be used; and an information that it will be removed in some future Fedora release. I've made a PR to the Docs [1], we should discuss its

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-06 Thread Neal Gompa
On Thu, Aug 6, 2020 at 7:12 AM Richard Shaw wrote: > > On Thu, Aug 6, 2020 at 5:35 AM Neal Gompa wrote: >> >> On Thu, Aug 6, 2020 at 6:20 AM Michal Schorm wrote: >> > >> > On Tue, Aug 4, 2020 at 5:54 PM Neal Gompa wrote: >> > > > On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa wrote: >> > > > > You

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-06 Thread Richard Shaw
On Thu, Aug 6, 2020 at 5:35 AM Neal Gompa wrote: > On Thu, Aug 6, 2020 at 6:20 AM Michal Schorm wrote: > > > > On Tue, Aug 4, 2020 at 5:54 PM Neal Gompa wrote: > > > > On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa > wrote: > > > > > You are not supposed to use %__cmake_builddir. > > > > > > It is

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-06 Thread Neal Gompa
On Thu, Aug 6, 2020 at 6:43 AM Michal Schorm wrote: > > On Thu, Aug 6, 2020 at 12:35 PM Neal Gompa wrote: > > > > On Thu, Aug 6, 2020 at 6:20 AM Michal Schorm wrote: > > > > > > On Tue, Aug 4, 2020 at 5:54 PM Neal Gompa wrote: > > > > > On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa wrote: > > > >

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-06 Thread Michal Schorm
On Thu, Aug 6, 2020 at 12:35 PM Neal Gompa wrote: > > On Thu, Aug 6, 2020 at 6:20 AM Michal Schorm wrote: > > > > On Tue, Aug 4, 2020 at 5:54 PM Neal Gompa wrote: > > > > On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa wrote: > > > > > You are not supposed to use %__cmake_builddir. > > > > > > It is

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-06 Thread Neal Gompa
On Thu, Aug 6, 2020 at 6:20 AM Michal Schorm wrote: > > On Tue, Aug 4, 2020 at 5:54 PM Neal Gompa wrote: > > > On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa wrote: > > > > You are not supposed to use %__cmake_builddir. > > > > It is not documented, and eventually will be removed. So don't rely on >

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-06 Thread Michal Schorm
On Tue, Aug 4, 2020 at 5:54 PM Neal Gompa wrote: > > On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa wrote: > > > You are not supposed to use %__cmake_builddir. > > It is not documented, and eventually will be removed. So don't rely on > it. If you want to change the build directory, set %_vpath_buildd

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Richard Shaw
On Tue, Aug 4, 2020 at 11:47 AM Neal Gompa wrote: > On Tue, Aug 4, 2020 at 11:50 AM Michal Schorm wrote: > > > > On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa wrote: > > > On Tue, Aug 4, 2020 at 9:10 AM Richard Shaw > wrote: > > > > On Tue, Aug 4, 2020 at 6:17 AM Michal Schorm > wrote: > > > >> >

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Neal Gompa
On Tue, Aug 4, 2020 at 11:50 AM Michal Schorm wrote: > > On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa wrote: > > On Tue, Aug 4, 2020 at 9:10 AM Richard Shaw wrote: > > > On Tue, Aug 4, 2020 at 6:17 AM Michal Schorm wrote: > > >> > > >> Since this change, all (subsequent) CMake commands (after "%cm

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Michal Schorm
On Tue, Aug 4, 2020 at 3:12 PM Neal Gompa wrote: > On Tue, Aug 4, 2020 at 9:10 AM Richard Shaw wrote: > > On Tue, Aug 4, 2020 at 6:17 AM Michal Schorm wrote: > >> > >> Since this change, all (subsequent) CMake commands (after "%cmake") > >> MUST be used with the builddir argument ( "-B %{__cmake

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Christoph Junghans
On Tue, Aug 4, 2020 at 7:22 AM Tom Hughes via devel wrote: > > On 04/08/2020 14:11, Neal Gompa wrote: > > On Tue, Aug 4, 2020 at 9:10 AM Richard Shaw wrote: > >> > >> On Tue, Aug 4, 2020 at 6:17 AM Michal Schorm wrote: > >>> > >>> Since this change, all (subsequent) CMake commands (after "%cmake

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Tom Hughes via devel
On 04/08/2020 14:11, Neal Gompa wrote: On Tue, Aug 4, 2020 at 9:10 AM Richard Shaw wrote: On Tue, Aug 4, 2020 at 6:17 AM Michal Schorm wrote: Since this change, all (subsequent) CMake commands (after "%cmake") MUST be used with the builddir argument ( "-B %{__cmake_builddir}" ). Ok, I'll

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Neal Gompa
On Tue, Aug 4, 2020 at 9:10 AM Richard Shaw wrote: > > On Tue, Aug 4, 2020 at 6:17 AM Michal Schorm wrote: >> >> Since this change, all (subsequent) CMake commands (after "%cmake") >> MUST be used with the builddir argument ( "-B %{__cmake_builddir}" ). > > > Ok, I'll use that in the future, but

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Richard Shaw
On Tue, Aug 4, 2020 at 6:17 AM Michal Schorm wrote: > Since this change, all (subsequent) CMake commands (after "%cmake") > MUST be used with the builddir argument ( "-B %{__cmake_builddir}" ). > Ok, I'll use that in the future, but it still needs a mention in the guidelines :) Thanks, RIchard

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Michal Schorm
Since this change, all (subsequent) CMake commands (after "%cmake") MUST be used with the builddir argument ( "-B %{__cmake_builddir}" ). I use in my packages "cmake -LAH" from time to time, to verify that all CMake arguments (-D...) were passed and processed correctly, since the processing logic

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-04 Thread Igor Raits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Mon, 2020-08-03 at 22:14 -0500, Richard Shaw wrote: > Sometimes you need to get into the build directory, in my case for > OpenColorIO I use help2man to generate some of the man pages. > > I had to rely on the power of Google/Gmail to find Neal's

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-03 Thread Tom Hughes via devel
On 04/08/2020 04:14, Richard Shaw wrote: I had to rely on the power of Google/Gmail to find Neal's response to one of my earlier emails to find the answer again... %{_vpath_builddir} But that begs the question, now that we have updated %cmake, and new %cmake_build & %cmake_install, why is it

Re: %{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-03 Thread Neal Gompa
On Mon, Aug 3, 2020 at 11:45 PM Richard Shaw wrote: > > Sometimes you need to get into the build directory, in my case for > OpenColorIO I use help2man to generate some of the man pages. > > I had to rely on the power of Google/Gmail to find Neal's response to one of > my earlier emails to find

%{_vpath_builddir} needs to be in the Cmake packaging guidelines

2020-08-03 Thread Richard Shaw
Sometimes you need to get into the build directory, in my case for OpenColorIO I use help2man to generate some of the man pages. I had to rely on the power of Google/Gmail to find Neal's response to one of my earlier emails to find the answer again... %{_vpath_builddir} But that begs the questio