Re: [389-devel] Please review lib389 ticket 47584: CI tests: add backup/restore of an instance

2013-11-06 Thread Roberto Polli
On Wednesday 06 November 2013 14:26:22 thierry bordaz wrote: for example log.level=info mean we log fatal/warning/debug ? Yes. Check import logging documentation. the verbose+log approach may have some performance advantage in webapp, but I think that's not the case see -

Re: [389-devel] Please review lib389 ticket 47584: CI tests: add backup/restore of an instance

2013-11-06 Thread Roberto Polli
On Wednesday 06 November 2013 14:12:33 thierry bordaz wrote: https://fedorahosted.org/389/attachment/ticket/47584/0001-Ticket-47584-CI-te sts-add-backup-restore-of-an-insta.patch I would delegate all the verbose stuff to log level, so just use log.debug() instead of if verbose: log.debug()

Re: [389-devel] Please review lib389 ticket 47584: CI tests: add backup/restore of an instance

2013-11-06 Thread thierry bordaz
On 11/06/2013 02:23 PM, Roberto Polli wrote: On Wednesday 06 November 2013 14:12:33 thierry bordaz wrote: https://fedorahosted.org/389/attachment/ticket/47584/0001-Ticket-47584-CI-te sts-add-backup-restore-of-an-insta.patch I would delegate all the verbose stuff to log level, so just use