Re: C++ help needed fixing VXL on 32 bit architectures

2019-05-28 Thread Roberto Ragusa
On 5/28/19 2:26 PM, Roberto Ragusa wrote: On 5/28/19 1:57 AM, John Reiser wrote:     if ((t&=7)==0) *++ib=0; int a; (*vs_) >> a; if (a) *ib|=static_cast(1<<(7-t)); } Such code is an abomination for lack of clarity. Also, the preceding line for (int

Re: C++ help needed fixing VXL on 32 bit architectures

2019-05-28 Thread Roberto Ragusa
On 5/28/19 1:57 AM, John Reiser wrote:    if ((t&=7)==0) *++ib=0; int a; (*vs_) >> a; if (a) *ib|=static_cast(1<<(7-t)); }     Such code is an abomination for lack of clarity.     Also, the preceding line     for (int x=0,t=0; x Isn't t forced into 0..6 by the

Re: C++ help needed fixing VXL on 32 bit architectures

2019-05-28 Thread Ankur Sinha
Hi John, On Mon, May 27, 2019 16:57:18 -0700, John Reiser wrote: > > https://github.com/vxl/vxl/issues/638 > > Independent of that particular issue, it is hard to believe the claim > "vxl: A multi-platform collection of C++ software libraries ...". > They're not making a good-faith effort to be

Re: C++ help needed fixing VXL on 32 bit architectures

2019-05-28 Thread Ankur Sinha
Dear Jerry, On Mon, May 27, 2019 15:33:42 -0600, Jerry James wrote: > On Mon, May 27, 2019 at 2:54 PM Jerry James wrote: > > It looks like the first few errors, at least, were fixed the day after > > the last release, in this commit: > > > >

Re: C++ help needed fixing VXL on 32 bit architectures

2019-05-27 Thread John Reiser
https://github.com/vxl/vxl/issues/638 Independent of that particular issue, it is hard to believe the claim "vxl: A multi-platform collection of C++ software libraries ...". They're not making a good-faith effort to be portable. The first hint is that "-Werror" (turn all warnings into errors)

Re: C++ help needed fixing VXL on 32 bit architectures

2019-05-27 Thread Jerry James
On Mon, May 27, 2019 at 2:54 PM Jerry James wrote: > It looks like the first few errors, at least, were fixed the day after > the last release, in this commit: > > https://github.com/vxl/vxl/commit/c3fd27959f51e0469a7a6075e975f245ac306f3d > > You might try adding that as a patch and see if that

Re: C++ help needed fixing VXL on 32 bit architectures

2019-05-27 Thread Jerry James
On Mon, May 27, 2019 at 10:14 AM Ankur Sinha wrote: > After spending quite a bit of time fixing VXL to build, I've now run > into errors with it building on 32 bit arches. > > Unfortunately, I don't foresee myself having enough cycles in the near > future to debug the C++ bits to see what's

C++ help needed fixing VXL on 32 bit architectures

2019-05-27 Thread Ankur Sinha
Hi everyone, After spending quite a bit of time fixing VXL to build, I've now run into errors with it building on 32 bit arches. Unfortunately, I don't foresee myself having enough cycles in the near future to debug the C++ bits to see what's happening here, and while I have filed a ticket