Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-05 Thread Richard Shaw
On Fri, Nov 5, 2021 at 5:47 AM Timm Bäder wrote: > > > If this change is implemented, manual removal in packages becomes > unnecessary. > > Will you do a 'mass change' sweep to drop those removals? > > I've already looked at all the packages I listed, so looking at them again > shouldn't be > a

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-05 Thread Timm Bäder
> If this change is implemented, manual removal in packages becomes unnecessary. > Will you do a 'mass change' sweep to drop those removals? I've already looked at all the packages I listed, so looking at them again shouldn't be a problem. But that's just the list of packages that currently

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-05 Thread Timm Bäder
> This looks like it risks deleting more files than intended. If some > package uses country codes or domain names in filenames, then this > change could silently delete files specific to Laos. None of the packages I inspected looked like they would do this, but I opened

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-04 Thread Jason Tibbitts
> Rex Dieter writes: > I'm sure there's a way to opt-out of this behavior (right?) There is a standard way to opt out of any of the brp scripts: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_brp_buildroot_policy_scripts - J< ___

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-04 Thread Rex Dieter
Kevin Kofler via devel wrote: > Zbigniew Jędrzejewski-Szmek wrote: >> Why would anyone want to do that? (I'm not talking about the case >> mentioned elsewhere in the thread were a non-libtool file is removed >> by a mistake, but the actual case where one would want to keep >> distributing a

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-02 Thread Florian Weimer
* Zbigniew Jędrzejewski-Szmek: > I read the mythbuster page, and I still don't understand if removing > the file has any effect or not. Will there be any difference in builds > (for package builds and end-user builds)? As far as I understand it, linking with static libraries using libtool will

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Ben Beasley
I think Björn Persson’s concerns are reasonable. Hopefully they can be easily addressed, since I would be happy to see this change implemented. At least six packages I maintain or regularly contribute to could be simplified. I spot-checked a libtool .la file to see what typical contents

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Kevin Kofler via devel
Zbigniew Jędrzejewski-Szmek wrote: > Why would anyone want to do that? (I'm not talking about the case > mentioned elsewhere in the thread were a non-libtool file is removed > by a mistake, but the actual case where one would want to keep > distributing a libtool file.) The kdelibs3 plugin loader

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Vitaly Zaitsev via devel
On 01/11/2021 14:37, Ben Cotton wrote: Autools/libtool-based projects frequently install files ending in `.la` in their `make install`. These files are usually unwanted. Many projects therefore end up with a variation of `find $RPM_BUILD_ROOT -name "*.la" -delete` in their `%install section`.

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Nov 01, 2021 at 09:37:40AM -0400, Ben Cotton wrote: > == Summary == > Autools/libtool-based projects frequently install files ending in > `.la` in their `make install`. These files are usually unwanted. Many > projects therefore end up with a variation of `find $RPM_BUILD_ROOT > -name

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Björn Persson
> Pull request implementing `%__brp_remove_la_files` in the upstream rpm > repository: https://github.com/rpm-software-management/rpm/pull/1674 This looks like it risks deleting more files than intended. If some package uses country codes or domain names in filenames, then this change could

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Petr Pisar
V Mon, Nov 01, 2021 at 02:50:27PM +, Richard W.M. Jones napsal(a): > There are quite a few of these "junk files" left around by build systems > that many packages have to remove: > > - .packlist (Perl) > These are actually useful for a few Perl tools which need to enumarate installed CPAN

Re: F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Richard W.M. Jones
On Mon, Nov 01, 2021 at 09:37:40AM -0400, Ben Cotton wrote: > https://fedoraproject.org/wiki/Changes/RemoveLaFiles > > == Summary == > Autools/libtool-based projects frequently install files ending in > `.la` in their `make install`. These files are usually unwanted. Many > projects therefore end

F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/RemoveLaFiles == Summary == Autools/libtool-based projects frequently install files ending in `.la` in their `make install`. These files are usually unwanted. Many projects therefore end up with a variation of `find $RPM_BUILD_ROOT -name "*.la" -delete` in

F36 Change: Remove .la files from buildroot (Self-Contained Change proposal)

2021-11-01 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/RemoveLaFiles == Summary == Autools/libtool-based projects frequently install files ending in `.la` in their `make install`. These files are usually unwanted. Many projects therefore end up with a variation of `find $RPM_BUILD_ROOT -name "*.la" -delete` in