Re: Package review template

2010-11-02 Thread Jean-Francois Saucier
Thanks to everyone for pointing me scripts and other templates. I will take a look at them and it will help me figure out a good starting point. On Mon, Nov 1, 2010 at 10:58 AM, Stanislav Ochotnicky sochotni...@redhat.com wrote: I'd like to see links to packaging guidelines for each point

Re: Package review template

2010-11-02 Thread Stanislav Ochotnicky
On 11/02/2010 01:35 PM, Jean-Francois Saucier wrote: On Mon, Nov 1, 2010 at 10:58 AM, Stanislav Ochotnicky sochotni...@redhat.com wrote: I'd like to see links to packaging guidelines for each point (or at least for non-obvious ones). It's helpful for the both parties to know why they have to

Re: Package review template

2010-11-02 Thread Jean-Francois Saucier
On Tue, Nov 2, 2010 at 8:43 AM, Stanislav Ochotnicky sochotni...@redhat.com wrote: What we did is we have references[1]. They seem to work fairly well and they are not too noisy IMO. YMMV of course. Yes, maybe that would do the trick if there are not too many references in the template. I will

Re: Package review template

2010-11-02 Thread Till Maas
On Tue, Nov 02, 2010 at 08:35:41AM -0400, Jean-Francois Saucier wrote: Thanks to everyone for pointing me scripts and other templates. I will take a look at them and it will help me figure out a good starting point. All templates I know are linked here:

Package review template

2010-11-01 Thread Jean-Francois Saucier
Hi everyone, I just put my package review template on my wiki space at : https://fedoraproject.org/wiki/User:Jfsaucier/Review_Template My template is simply a collection based on other's already existing template. What I did is I tried to put missing checks and sort them in an order that should

Re: Package review template

2010-11-01 Thread Stanislav Ochotnicky
On 11/01/2010 03:32 PM, Jean-Francois Saucier wrote: Hi everyone, I just put my package review template on my wiki space at : https://fedoraproject.org/wiki/User:Jfsaucier/Review_Template I created something similar specifically for Java reviews with Java SIG members improving it bit by bit

Re: Package review template

2010-11-01 Thread Jaroslav Skarvada
I plan to put up some scripts to automate part of the review process as soon as I have the time to finish them. Great idea. I hacked a little script some time ago. It may be a little outdated now, non optimally designed, but maybe something could be reused in your project:

Re: Package review template

2010-11-01 Thread Pierre-Yves
On Mon, 2010-11-01 at 15:58 +0100, Stanislav Ochotnicky wrote: I plan to put up some scripts to automate part of the review process as soon as I have the time to finish them. Some time ago I put this together: http://project.pingoured.fr/reviewHelper/ The idea here is of course not to do

Re: Package review template

2010-11-01 Thread Garrett Holmstrom
On 11/1/2010 9:32, Jean-Francois Saucier wrote: I just put my package review template on my wiki space at : https://fedoraproject.org/wiki/User:Jfsaucier/Review_Template [ ] SourceX is a working URL. [ ] SourceX / PatchY prefixed with %{name}. [ ] Final provides and requires are sane (rpm -q