Re: Update of catch to Catch2 v3

2023-03-01 Thread Vitaly Zaitsev via devel
On 01/03/2023 12:26, Vitaly Zaitsev wrote: Found issue. Current Fedora catch v3 build uses Debug configuration and fails on assertions (src/catch2/catch_test_case_info.cpp:147). Fixed this issue in upstream. But switching Fedora package to the Release configuration will be great too. --

Re: Update of catch to Catch2 v3

2023-03-01 Thread Vitaly Zaitsev via devel
On 28/02/2023 17:05, Vitaly Zaitsev wrote: The tests passed on GitHub CI, but not on Fedora Koji. Maybe FORTIFY_SOURCE=3 or GLIB assertions strikes again. Found issue. Current Fedora catch v3 build uses Debug configuration and fails on assertions (src/catch2/catch_test_case_info.cpp:147).

Re: Update of catch to Catch2 v3

2023-02-28 Thread Vitaly Zaitsev via devel
On 28/02/2023 12:28, Tom Hughes wrote: Nothing to do with me. I don't do ELN. Got it. I'm working with upstream on porting spdlog to catch v3: https://github.com/gabime/spdlog/pull/2656 The tests passed on GitHub CI, but not on Fedora Koji. Maybe FORTIFY_SOURCE=3 or GLIB assertions strikes

Re: Update of catch to Catch2 v3

2023-02-28 Thread Tom Hughes via devel
On 28/02/2023 11:24, Vitaly Zaitsev via devel wrote: On 24/02/2023 09:42, Tom Hughes wrote: Did you miss the bit where I said you needed to change your BR to catch2-devel unless upstream has v3 support? What about Fedora ELN? catch2-devel is not available there. Nothing to do with me. I

Re: Update of catch to Catch2 v3

2023-02-28 Thread Vitaly Zaitsev via devel
On 24/02/2023 09:42, Tom Hughes wrote: Did you miss the bit where I said you needed to change your BR to catch2-devel unless upstream has v3 support? What about Fedora ELN? catch2-devel is not available there. -- Sincerely, Vitaly Zaitsev (vit...@easycoding.org)

Re: Update of catch to Catch2 v3

2023-02-27 Thread Jonathan Wakely
On Fri, 24 Feb 2023 at 08:20, Vitaly Zaitsev via devel wrote: > > On 24/02/2023 09:06, Benson Muite wrote: > > No. There are incompatibilities. Maybe it is better to keep the old > > name, and use Catch2v3 as a new name, so packages can update more easily > > when they are ready to do so? > >

Re: Update of catch to Catch2 v3

2023-02-24 Thread Neal Gompa
On Fri, Feb 24, 2023 at 6:22 AM Vitaly Zaitsev via devel wrote: > > On 24/02/2023 09:42, Tom Hughes wrote: > > Did you miss the bit where I said you needed to change > > your BR to catch2-devel unless upstream has v3 support? > > I want to fix them correctly, i.e. port to catch v3 and send a PR

Re: Update of catch to Catch2 v3

2023-02-24 Thread Vitaly Zaitsev via devel
On 24/02/2023 09:42, Tom Hughes wrote: Did you miss the bit where I said you needed to change your BR to catch2-devel unless upstream has v3 support? I want to fix them correctly, i.e. port to catch v3 and send a PR to upstream. -- Sincerely, Vitaly Zaitsev (vit...@easycoding.org)

Re: Update of catch to Catch2 v3

2023-02-24 Thread Tom Hughes via devel
On 24/02/2023 07:48, Vitaly Zaitsev via devel wrote: On 22/02/2023 12:37, Tom Hughes via devel wrote: I have now added catch2 (for Catch2 v2.x) and upgraded the catch package to Catch2 v3.x in rawhide and f38. All my catch-dependent packages are now failing due to the missing catch.hpp

Re: Update of catch to Catch2 v3

2023-02-24 Thread Vitaly Zaitsev via devel
On 24/02/2023 09:06, Benson Muite wrote: No. There are incompatibilities. Maybe it is better to keep the old name, and use Catch2v3 as a new name, so packages can update more easily when they are ready to do so? Fedora should go forward. Some packages can be patched trivially: #if

Re: Update of catch to Catch2 v3

2023-02-24 Thread Benson Muite
On 2/24/23 10:48, Vitaly Zaitsev via devel wrote: > On 22/02/2023 12:37, Tom Hughes via devel wrote: >> I have now added catch2 (for Catch2 v2.x) and upgraded the catch >> package to Catch2 v3.x in rawhide and f38. > > All my catch-dependent packages are now failing due to the missing > catch.hpp

Re: Update of catch to Catch2 v3

2023-02-23 Thread Vitaly Zaitsev via devel
On 22/02/2023 12:37, Tom Hughes via devel wrote: I have now added catch2 (for Catch2 v2.x) and upgraded the catch package to Catch2 v3.x in rawhide and f38. All my catch-dependent packages are now failing due to the missing catch.hpp header: tests.cpp:32:10: fatal error: catch.hpp: No such

Re: Update of catch to Catch2 v3

2023-02-23 Thread Stephen Gallagher
On Wed, Feb 22, 2023 at 6:38 AM Tom Hughes via devel wrote: > > As discussed a few weeks ago the Catch testing framework has > a slightly weird naming scheme, namely: > > * Catch (v1.x, actually a branch in Catch2 repository) > * Catch2 v2.x > * Catch2 v3.x > > Since Catch2 was released we have

Re: Update of catch to Catch2 v3

2023-02-23 Thread Benson Muite
On 2/22/23 14:37, Tom Hughes via devel wrote: > As discussed a few weeks ago the Catch testing framework has > a slightly weird naming scheme, namely: > > * Catch (v1.x, actually a branch in Catch2 repository) > * Catch2 v2.x > * Catch2 v3.x > > Since Catch2 was released we have had catch1 and

Update of catch to Catch2 v3

2023-02-22 Thread Tom Hughes via devel
As discussed a few weeks ago the Catch testing framework has a slightly weird naming scheme, namely: * Catch (v1.x, actually a branch in Catch2 repository) * Catch2 v2.x * Catch2 v3.x Since Catch2 was released we have had catch1 and catch packages to support both v1.x and v2.x users. I have