gcc-4.6.0-0.11.fc15.x86_64 breaks strcmp?

2011-03-07 Thread Richard W.M. Jones
Compiling libguestfs using gcc-4.6.0-0.11.fc15.x86_64 gives lots of: error: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C1 +- C2 [-Werror=strict-overflow] These seem to be associated with code that does 'if (strcmp (s1, s2) == 0)' For example: dir.c: In

Re: gcc-4.6.0-0.11.fc15.x86_64 breaks strcmp?

2011-03-07 Thread Adam Jackson
On 3/7/11 9:49 AM, Richard W.M. Jones wrote: Compiling libguestfs using gcc-4.6.0-0.11.fc15.x86_64 gives lots of: error: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C1 +- C2 [-Werror=strict-overflow] These seem to be associated with code that does 'if

gcc-4.6.0-0.12.fc15.x86_64 breaks strcmp? (was: Re: gcc-4.6.0-0.11.fc15.x86_64 breaks strcmp?)

2011-03-07 Thread Richard W.M. Jones
On Mon, Mar 07, 2011 at 10:14:57AM -0500, Adam Jackson wrote: On 3/7/11 9:49 AM, Richard W.M. Jones wrote: Compiling libguestfs using gcc-4.6.0-0.11.fc15.x86_64 gives lots of: error: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C1 +- C2

Re: gcc-4.6.0-0.11.fc15.x86_64 breaks strcmp?

2011-03-07 Thread yersinia
On Mon, Mar 7, 2011 at 3:49 PM, Richard W.M. Jones rjo...@redhat.com wrote: Compiling libguestfs using gcc-4.6.0-0.11.fc15.x86_64 gives lots of: error: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C1 +- C2 [-Werror=strict-overflow] These seem to be

Re: gcc-4.6.0-0.11.fc15.x86_64 breaks strcmp?

2011-03-07 Thread Richard W.M. Jones
On Mon, Mar 07, 2011 at 04:37:20PM +0100, yersinia wrote: I remeber that gnu lib have a similar macro, and last year there was a fix http://old.nabble.com/-PATCH--define-STREQ%28a,-b%29-consistently,-removing-useless-parentheses-td27293621.html I understand Jim's argument, although I think

Re: gcc-4.6.0-0.11.fc15.x86_64 breaks strcmp?

2011-03-07 Thread Jim Meyering
Richard W.M. Jones wrote: Compiling libguestfs using gcc-4.6.0-0.11.fc15.x86_64 gives lots of: error: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C1 +- C2 [-Werror=strict-overflow] These seem to be associated with code that does 'if (strcmp (s1, s2) == 0)'

Re: gcc-4.6.0-0.11.fc15.x86_64 breaks strcmp?

2011-03-07 Thread Jakub Jelinek
On Mon, Mar 07, 2011 at 05:09:17PM +0100, Jim Meyering wrote: I suspect that there was a problem with .11, perhaps one of these: * Fri Mar 04 2011 Jakub Jelinek ja...@redhat.com 4.6.0-0.12 - update from trunk - PRs c++/46159, c++/46282, c++/47200, c++/47774, c++/47851,