Re: sorting of git N-V-R tags in rpm package repositories

2020-05-08 Thread clime
On Thu, 7 May 2020 at 20:50, Kevin Fenzi wrote: > > On Tue, May 05, 2020 at 06:46:48PM +0200, Florian Weimer wrote: > ...snip... > > > > The latest tag for a source package name wins for the Koji-generatged > > repository. I don't know what happens if different source packages > > build

Re: sorting of git N-V-R tags in rpm package repositories

2020-05-07 Thread Kevin Fenzi
On Tue, May 05, 2020 at 06:46:48PM +0200, Florian Weimer wrote: ...snip... > > The latest tag for a source package name wins for the Koji-generatged > repository. I don't know what happens if different source packages > build subpackages of the same name. koji operates on source packages, so as

Re: sorting of git N-V-R tags in rpm package repositories

2020-05-06 Thread clime
> Well, if you don't push the tag and you do a build, you will get N-V-R > like foo-1.0-1.git.3.abcdef12. E.g. it won't be a clean N-V-R because I meant "I.e." there, not "E.g."...just to be clear. > it doesn't come from a tagged commit. If you push a tag and repeat a > build from that same

Re: sorting of git N-V-R tags in rpm package repositories

2020-05-06 Thread clime
On Wed, 6 May 2020 at 11:00, Florian Weimer wrote: > > >> >> Tags can also be added retroactively and backdated. These things > >> >> conflict with the advantages you list (in particular, with NVR > >> >> auto-generation, git is not the sole source of truth). > >> > > >> > If the tag ordering

Re: sorting of git N-V-R tags in rpm package repositories

2020-05-06 Thread Florian Weimer
>> >> Tags can also be added retroactively and backdated. These things >> >> conflict with the advantages you list (in particular, with NVR >> >> auto-generation, git is not the sole source of truth). >> > >> > If the tag ordering function is done properly, I believe even >> > retroactive tagging

Re: sorting of git N-V-R tags in rpm package repositories

2020-05-06 Thread clime
On Tue, 5 May 2020 at 18:46, Florian Weimer wrote: > > > Hey Florian, > > > > On Mon, 4 May 2020 at 10:03, Florian Weimer wrote: > >> > >> > as part of https://hackmd.io/kIje9yXTRdWITwP7cFK2pA (annotated tags > >> > pushed by package maintainers) effort, I revisited the sorting > >> > algorithm

Re: sorting of git N-V-R tags in rpm package repositories

2020-05-05 Thread Florian Weimer
> Hey Florian, > > On Mon, 4 May 2020 at 10:03, Florian Weimer wrote: >> >> > as part of https://hackmd.io/kIje9yXTRdWITwP7cFK2pA (annotated tags >> > pushed by package maintainers) effort, I revisited the sorting >> > algorithm that is used to determine the "latest" tag for a given >> > package

Re: sorting of git N-V-R tags in rpm package repositories

2020-05-05 Thread clime
On Tue, 5 May 2020 at 11:35, clime wrote: > > Hey Florian, > > On Mon, 4 May 2020 at 10:03, Florian Weimer wrote: > > > > > as part of https://hackmd.io/kIje9yXTRdWITwP7cFK2pA (annotated tags > > > pushed by package maintainers) effort, I revisited the sorting > > > algorithm that is used to

sorting of git N-V-R tags in rpm package repositories

2020-05-05 Thread clime
Hey Florian, On Mon, 4 May 2020 at 10:03, Florian Weimer wrote: > > > as part of https://hackmd.io/kIje9yXTRdWITwP7cFK2pA (annotated tags > > pushed by package maintainers) effort, I revisited the sorting > > algorithm that is used to determine the "latest" tag for a given > > package which is

Re: sorting of git N-V-R tags in rpm package repositories

2020-05-04 Thread Florian Weimer
> as part of https://hackmd.io/kIje9yXTRdWITwP7cFK2pA (annotated tags > pushed by package maintainers) effort, I revisited the sorting > algorithm that is used to determine the "latest" tag for a given > package which is needed to determine correct package version. > Basically, if the current

sorting of git N-V-R tags in rpm package repositories

2020-05-03 Thread clime
Hello, as part of https://hackmd.io/kIje9yXTRdWITwP7cFK2pA (annotated tags pushed by package maintainers) effort, I revisited the sorting algorithm that is used to determine the "latest" tag for a given package which is needed to determine correct package version. Basically, if the current commit